-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX/UI for Ignore Restriction - Bypass Add/Remove #3691
Comments
18 tasks
@Joshua-Lakusta @CarlyCotton Should the new permission to bypass restriction be added to all AEST groups or only Business Administrators? |
@andrepestana-aot Can you link that to only business-administrator group for now? Edit: Updated AC to reflect just the one group. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 13, 2024
…3905) - Created the api endpoints: - GET aest/application-restriction-bypass/:id - GET aest/application-restriction-bypass/application/:applicationId/options-list - POST aest/application-restriction-bypass - PATCH aest/application-restriction-bypass/:id - Added new role "aest-bypass-student-restriction" only for business administrators; - Added e2e tests: - ApplicationRestrictionBypassAESTController(e2e)-bypassRestriction √ Should be able to create a bypass when there is not an active bypass for the same student. √ Should throw an HTTP error while creating a bypass when there is an active bypass for the same active student restriction. √ Should throw an HTTP error while creating a bypass when student restriction is not active. √ Should throw an HTTP error while creating a bypass when the student application is in draft. √ Should throw an HTTP error while creating a bypass when the student application is in cancelled. - ApplicationRestrictionBypassAESTController(e2e)-getApplicationRestrictionBypass. √ Should get an application restriction bypass for a submitted part-time application when there is an application restriction bypass with the required id. √ Should get an inactive application restriction bypass for a submitted part-time application when there is an application restriction bypass with the required id. - ApplicationRestrictionBypassAESTController(e2e)-getAvailableRestrictionsToBypass. √ Should list all student active restrictions and not already bypassed for a part-time application when there is one restriction bypassed and some others not. √ Should list all student active restrictions for a full-time application when there is one restriction bypassed and others not. - ApplicationRestrictionBypassAESTController(e2e)-removeBypassRestriction √ Should be able to remove an active bypass when there is an active bypass. √ Should throw an HTTP error while removing a bypass when the bypass is not active. √ Should throw an HTTP error while removing a bypass when the bypass is not found.
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2024
Fix for the circular dependency error caused by anonymous TypeScript type. ![image](https://github.com/user-attachments/assets/2c8d62e5-dfc3-477e-a542-424fa6ba923e)
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 20, 2024
) Created modals: - Ministry 'Bypass Restriction' Modal - Ministry 'View Details' Modal - Bypass was Removed - Ministry 'Remove Bypass' Modal Table with buttons: ![image](https://github.com/user-attachments/assets/3bb00701-5fdd-47d3-ac13-6db95ff03af5) Remove bypass: ![image](https://github.com/user-attachments/assets/72971686-e329-42fd-b848-e9da8ebae24a) Bypass application restriction: ![image](https://github.com/user-attachments/assets/b6346a80-ca08-42fd-be1b-8dccc6bcdaf7) View details: ![image](https://github.com/user-attachments/assets/8502ee4b-de4b-451c-8d10-365d82c15911)
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 20, 2024
Fix for when the student doesn't have any student restrictions in the API.
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 21, 2024
…p part time BC funding" action type (#3977) - Added StopPartTimeBCFunding restriction action type to the query that gets the available student restrictions to be bypassed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
As a Ministry user, I need the ability to Ignore restrictions through the interface, as well as see some limited historical details of any ignored restrictions
Acceptance Criteria
business-administrators
.Technical
is_active
: false.bypass_removed_date
: current date.bypass_removed_by
: Ministry user.removal_note_id
: create a related note.sims.student_restrictions
table. The same restriction code may have multiple active entries in the student restrictions. Format sampleB3D added on Aug 28 2024
.Stop full time BC funding
orStop full time disbursement
.Stop part time disbursement
or "Stop part-time BC funding"is_active
: true.bypass_created_date
: current date.bypass_created_by
: Ministry user.creation_note_id
: create a related note.bypass_behavior
: selected behavior from the UI. Ensure DTO validation.student_restriction_id
: selected from the UI. Ensure the logic to populate the dropdown options will be checked in the API.GET
aest/application-restriction-bypass/:idGET
aest/application-restriction-bypass/application/:applicationId/options-listPOST
aest/application-restriction-bypassPATCH
aest/application-restriction-bypass/:idSupporting Mockups
These mockups follow a similar approach from the Ministry adding and removing restrictions. Please use that feature as a reference.
Ministry 'Bypass Restriction' Modal
![image](https://private-user-images.githubusercontent.com/61259237/362947411-00779910-3f28-48f7-852b-198ab0260d3d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjc4NjAsIm5iZiI6MTczODkyNzU2MCwicGF0aCI6Ii82MTI1OTIzNy8zNjI5NDc0MTEtMDA3Nzk5MTAtM2YyOC00OGY3LTg1MmItMTk4YWIwMjYwZDNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExMjYwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMmQ4ZTZiZDBmZTVlZTEyNzJlOGY2MWY2NDQ3NmY0YjAxYjdiMzRhMTE4ZTRkM2FhYzkyYTliN2RmMDE5MjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yAARIbzldHMBanz1wDly9UNSRsUCvFcu7wqVdB2KAjI)
Ministry 'View Details' Modal - Bypass was Removed
![image](https://private-user-images.githubusercontent.com/61259237/362903754-8d0db57b-2d11-4737-88dd-7369b3ea861d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjc4NjAsIm5iZiI6MTczODkyNzU2MCwicGF0aCI6Ii82MTI1OTIzNy8zNjI5MDM3NTQtOGQwZGI1N2ItMmQxMS00NzM3LTg4ZGQtNzM2OWIzZWE4NjFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExMjYwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVkNWUwYjgzYjNlMTgxYmM5MzdhMTIwOTc0ODJjMGYwMTJhZGFiNjBjZWJmYTEzYWFhM2U1NTAyMTJhYTc0YjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.k_zi6KKgtFHFkT54xymSPPSX3bvS9AiTAG2y1DLQ-q4)
Ministry 'Remove Bypass' Modal
![image](https://private-user-images.githubusercontent.com/61259237/362955864-75ba37d9-9e39-49d1-bae7-1963911f4e90.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjc4NjAsIm5iZiI6MTczODkyNzU2MCwicGF0aCI6Ii82MTI1OTIzNy8zNjI5NTU4NjQtNzViYTM3ZDktOWUzOS00OWQxLWJhZTctMTk2MzkxMWY0ZTkwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExMjYwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkODQ0NDFmNzZkMjNkMmFkM2IzOGQwMGVjNDUwNDQwODgyMTY4MmI3ZjY0YTIxYjhhYTM1MGUwZjZhNDhmYzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.azfLsICL4u-YeKhnV9IeVHECPkdm2GbtsIImOGACfSs)
The text was updated successfully, but these errors were encountered: