Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3691 - Fix for the cyclic dependency #3938

Merged

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Nov 14, 2024

Fix for the circular dependency error caused by anonymous TypeScript type.
image

@andrepestana-aot andrepestana-aot self-assigned this Nov 14, 2024
@andrepestana-aot andrepestana-aot added the Bug Something isn't working label Nov 14, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.25% ( 3721 / 16720 )
Methods: 10.29% ( 214 / 2079 )
Lines: 25.61% ( 3229 / 12607 )
Branches: 13.67% ( 278 / 2034 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.92% ( 1243 / 1430 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.77% ( 1055 / 1202 )
Branches: 72.73% ( 64 / 88 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, looks good 👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.88% ( 5769 / 8626 )
Methods: 64.65% ( 715 / 1106 )
Lines: 70.82% ( 4532 / 6399 )
Branches: 46.57% ( 522 / 1121 )

@andrepestana-aot andrepestana-aot changed the title fix for the cyclic dependency #3691 - Fix for the cyclic dependency Nov 14, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review November 14, 2024 22:08
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants