#3691 - Fix for the cyclic dependency (#3938)

Fix for the circular dependency error caused by anonymous TypeScript type. ![image](https://github.com/user-attachments/assets/2c8d62e5-dfc3-477e-a542-424fa6ba923e)
bcgov · Nov 14, 2024 · 019ac73 · 019ac73
1 parent 7bd8f95
commit 019ac73
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...trollers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts b/...trollers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts
@@ -21,7 +21,7 @@ import {
 import {
   ApplicationRestrictionBypassAPIOutDTO,
   ApplicationRestrictionBypassHistoryAPIOutDTO,
-  AvailableStudentRestrictionAPIOutDTO,
+  AvailableStudentRestrictionsAPIOutDTO,
   BypassRestrictionAPIInDTO,
   RemoveBypassRestrictionAPIInDTO,
 } from "./models/application-restriction-bypass.dto";
@@ -136,7 +136,7 @@ export class ApplicationRestrictionBypassAESTController extends BaseController {
   @Get("application/:applicationId/options-list")
   async getAvailableStudentRestrictionsToBypass(
     @Param("applicationId", ParseIntPipe) applicationId: number,
-  ): Promise<AvailableStudentRestrictionAPIOutDTO> {
+  ): Promise<AvailableStudentRestrictionsAPIOutDTO> {
     const availableRestrictionsToBypass =
       await this.applicationRestrictionBypassService.getAvailableStudentRestrictionsToBypass(
         applicationId,

diff --git a/...e-controllers/application-restriction-bypass/models/application-restriction-bypass.dto.ts b/...e-controllers/application-restriction-bypass/models/application-restriction-bypass.dto.ts
@@ -41,11 +41,13 @@ export class RemoveBypassRestrictionAPIInDTO {
 }
 
 export class AvailableStudentRestrictionAPIOutDTO {
-  availableRestrictionsToBypass: {
-    studentRestrictionId: number;
-    restrictionCode: string;
-    studentRestrictionCreatedAt: Date;
-  }[];
+  studentRestrictionId: number;
+  restrictionCode: string;
+  studentRestrictionCreatedAt: Date;
+}
+
+export class AvailableStudentRestrictionsAPIOutDTO {
+  availableRestrictionsToBypass: AvailableStudentRestrictionAPIOutDTO[];
 }
 
 export class ApplicationRestrictionBypassAPIOutDTO {