Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3691 - UX/UI for Ignore Restriction - API bugfix #3969

Merged
merged 2 commits into from
Nov 20, 2024
Merged

#3691 - UX/UI for Ignore Restriction - API bugfix #3969

merged 2 commits into from
Nov 20, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Nov 20, 2024 •
edited
Loading

Fix for when the student doesn't have any student restrictions in the API.

@andrepestana-aot andrepestana-aot self-assigned this Nov 20, 2024
@andrepestana-aot andrepestana-aot added Bug Something isn't working SIMS-Api SIMS-Api labels Nov 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.1% ( 3718 / 16824 )
Methods: 10.19% ( 214 / 2100 )
Lines: 25.44% ( 3226 / 12682 )
Branches: 13.61% ( 278 / 2042 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review November 20, 2024 20:38
@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.93% ( 1244 / 1431 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.78% ( 1056 / 1203 )
Branches: 72.73% ( 64 / 88 )

bidyashish
bidyashish approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot self-requested a review November 20, 2024 21:09
@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.94% ( 5774 / 8625 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.87% ( 4531 / 6393 )
Branches: 46.71% ( 525 / 1124 )

dheepak-aot
dheepak-aot approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 7f2a108 Nov 20, 2024
20 checks passed
@andrepestana-aot andrepestana-aot deleted the 3691_uxui_for_ignore_restriction_bypass_add_remove_UI_modals_api_bug branch November 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidyashish bidyashish bidyashish approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
Bug Something isn't working SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @bidyashish @dheepak-aot