Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ministry - Filter/Search Programs & Offerings #2741

Closed
8 of 13 tasks
CarlyCotton opened this issue Jan 26, 2024 · 7 comments
Closed
8 of 13 tasks

Ministry - Filter/Search Programs & Offerings #2741

CarlyCotton opened this issue Jan 26, 2024 · 7 comments
Assignees
@sh16011993 @CarlyCotton
Labels
Enhancement New feature or request Ministry Ministry Features
Milestone
2.X Post Part-Tim...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Jan 26, 2024 •
edited by dheepak-aot
Loading

User Story
As a ministry user, I need to search for programs by more than just name within each institution to be able to (quickly) assist Institutions. This involves having a way to search for all institutions or search by institution location code AND being able to filter when viewing/searching programs when viewing the programs of an institution.

Acceptance Criteria

  • Update the Programs view for ministry users within an Institution (Figure 1):
    • Add sorting options to the fields to allow ASC/DESC (Program Name, Location name, Status[Pending,Approved,Declined,Inactive])
    • Add new search options to allow better filtering: Program Name AND Location name AND Status (multiple choice option) with search button
  • If this component is shared with institutions, it's okay to update the institution side too.
  • Search options for Status should load with all options selected. If none are selected, show no programs.
  • Sorting by status will change the default when the page loads (priority) to an alphabetical sort of the status names.

Business Context
Figure 1
image.png

Technical

  • Create a new input to allow the search by the location name.
  • Create a multi-select drop-down (or similar) to allow filter multiple statuses. By default, all should be marked.
  • Add the search button.
  • All three search inputs will behave as an "and" logic if provided.
  • Convert the table to use Vuetify.
  • Sort program statuses as below (the below order was redefined during development by new business ACs).
    • Pending
    • Approved
    • Declined
    • Inactive
  • Ensure at least one E2E will be present to test the data retrieval.
@CarlyCotton
Copy link
Collaborator Author

QOL: SABC code, filter by location, better searching options

@CarlyCotton CarlyCotton self-assigned this Jan 26, 2024
@CarlyCotton CarlyCotton added Enhancement New feature or request Ministry Ministry Features Content Tasks related to UIUX content labels Jan 26, 2024
@ninosamson ninosamson removed the Content Tasks related to UIUX content label Feb 3, 2024
@HRAGANBC HRAGANBC changed the title Ministry - Filter/Search Programs Ministry - Filter/Search Programs & Offerings Apr 3, 2024
@ninosamson ninosamson added the Business Items under Business Consideration label Aug 16, 2024
@CarlyCotton
Copy link
Collaborator Author

Met with IPDT Aug 21 to confirm details of the enhancements in this ticket.

@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Sep 5, 2024
@andrewsignori-aot
Copy link
Collaborator

@CarlyCotton is there a particular order for the statuses?

  • They are the below ones:
  • Creation pending
  • Approved
  • Creation declined
  • Change under review
  • Change awaiting approval
  • Change overwritten
  • Change declined

@CarlyCotton
Copy link
Collaborator Author

@andrewsignori-aot Can we have options that align with the Status Tag that they can see for each program? Pending, Approved, Inactive, Declined

@CarlyCotton
Copy link
Collaborator Author

Updated the ACs to align with discussion today about MVP solution

@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 1, 2024
@sh16011993 sh16011993 self-assigned this Oct 17, 2024
sh16011993 added a commit that referenced this issue Oct 18, 2024
@sh16011993
#2741 - Ministry Filter: Search Programs & Offerings
35afb27 
- Converted Prime Vue table to Vuetify Data Table
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2024
@sh16011993
#2741 - Ministry Filter: Search Programs & Offerings [Data Table Conv…
2926208 
…ersion to Vuetify] (#3805)

### As a part of this PR, the following task was completed:

- Converted Prime Vue Table to Vuetify Data Table.

### Screenshots:

**Added the loader while the data table loads:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/fe5a72a5-f426-4431-b9fa-e2a8acf86b19">


----------------------------------------------------------------------------------------------------------------------------------

**Data table with data:**

<img width="1921" alt="image"
src="https://github.com/user-attachments/assets/8d278bfc-1e8a-4f81-8535-2a3c76af7f08">


----------------------------------------------------------------------------------------------------------------------------------

**Data table without any records:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/69521290-1315-4563-9b95-9b2ab9092890">
sh16011993 added a commit that referenced this issue Oct 23, 2024
@sh16011993
#2741 - Ministry Filter Search Programs and Offerings [Added Location…
4e8cf05 
… Search]
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2024
@sh16011993
#2741 - Ministry Filter Search Programs and Offerings [Location and P…
69840a9 
…rogram Status Search] (#3819)

### As a part of the PR, the following were completed:

- Added Location Search and Program Status Search for the institution
programs in the UI. Each of the searches act as an `&&` operation.
- Added sorting for the Location Name and the Program Status columns.
- Updated the `api` to include the `location` and the program status in
the pagination for the search and updated the `sql` query fetching the
result.

### Screenshots:

**Location Search and Program Status Search added:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/0cf6e1b9-3bcf-4d48-9eab-a3b6abe35df8">


-----------------------------------------------------------------------------------------

**Location Search with Program Search Empty and Program Statuses:
Pending and Inactive selected:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/9e4fd12c-83f2-4f62-a59a-02ef8df6b4c9">


------------------------------------------------------------------------------------------

**Both Location and Program Search with Program Statuses: Pending and
Approved selected**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/c7db9d35-6343-47e5-bd44-90bd40c1a27c">


-------------------------------------------------------------------------------------------

**Location Search along with the Program Status: Pending selected:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/04a575df-684a-4c49-85da-e758454e9d96">


-------------------------------------------------------------------------------------------

**Inactive Programs selected:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/fe3e3738-cb2c-4e4c-9092-ce1e79f35088">


--------------------------------------------------------------------------------------------

**Nothing selected from the Program Status filter:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/2e160fd8-8fab-4b4a-9a7b-993fde7c7f59">


---------------------------------------------------------------------------------------------

**Descending Sort by Program Status:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/d11ee1fa-cf04-4180-921b-51fecc80ec90">


---------------------------------------------------------------------------------------------

**Natural Sorting (without ASC / DESC selected) on page load:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/66a0e5dd-f465-4bf9-82e0-cd79facd37b4">


---------------------------------------------------------------------------------------------

**Ascending Sort by Program Status:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/5a9ded38-8e2a-4cfb-b61c-16a02d9c24e9">
sh16011993 added a commit that referenced this issue Nov 1, 2024
@sh16011993
#2741 - Ministry Filter: Search Programs and Offerings [e2e tests]
eac683c
@andrewsignori-aot
Copy link
Collaborator

@CarlyCotton @sh16011993 It is my understanding that based on a conversation between you two during development, the below decisions were made.

  1. Statuses will be sorted in alphabetical order (including Inactive, which is not a real status in the backend but it is displayed to the user as if it is).
  2. When no options are selected in the dropdown for the statuses, no items will be returned.

@CarlyCotton if the above ones do not represent the output of the conversation, please let me know, otherwise, please ensure these decisions will be persisted in the ACs. If they are and I am missing something, please let me know.

@CarlyCotton
Copy link
Collaborator Author

@sh16011993 I've updated the ACs:
image.png

Please let me know if this is out of line with what we discussed or if I should clarify further.
FYI @andrewsignori-aot

github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@sh16011993
#2741 - Ministry Filter: Search Programs and Offerings [e2e tests] (#…
942c8e3 
…3883)

### As a part of this PR, the following were completed:

- **Wrote the following e2e tests:**

**EducationProgramAESTController(e2e)-getProgramsSummary**
    
√ Should not retrieve any education programs when the search for the
programs is made and no program statuses are searched for including no
search for the inactive programs. (655 ms)
√ Should retrieve all the education programs when the search for the
programs is made and all program statuses are searched for including the
inactive programs. (385 ms)
√ Should retrieve all the inactive education programs when the search
for the programs is made and none of the program statuses are selected
except for the inactive programs. (359 ms)
√ Should retrieve all the pending, declined and inactive education
programs sorted by ascending program status when the search for the
programs is made and pending, declined program statuses are selected
along with the inactive programs. (380 ms)
√ Should retrieve all the approved and declined education programs when
the search for the programs is made and only the approved and declined
program statuses are selected. (349 ms)
√ Should retrieve all the approved and pending education programs
matching the program name search string when the search for the programs
is made and the approved and pending program statuses are selected along
with the program name search filter. (370 ms)
√ Should retrieve all the declined and inactive education programs
sorted by ascending program status matching the program name search
string and the location name search string when the search for the
programs is made and the declined program status is selected along with
the inactive programs selected and the program name and location name
search filter. (623 ms)


------------------------------------------------------------------------------------------------------

### Screenshot of the executed tests:

<img width="1452" alt="image"
src="https://github.com/user-attachments/assets/ae7df65f-03d1-46b0-996f-ae4b540af9c8">


------------------------------------------------------------------------------------------------------

- **Fixed the issue where the checkbox doesn't show for the `v-select`
component when the list item is unchecked.**


**Issue:**

<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/95403598-bd41-446e-b216-66e41900387c">


------------------------------------------------------------------------------------------------------

**Fix:**

<img width="1918" alt="image"
src="https://github.com/user-attachments/assets/4758be7b-c788-48cd-9f43-dd376ad9dd88">
sh16011993 added a commit that referenced this issue Nov 12, 2024
@sh16011993
#2741 - Ministry Filter Search Programs and Offerings (Fix Expired Pr…
aecddcb 
…ograms)
github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024
@sh16011993
#2741 - Ministry Filter Search Programs and Offerings [Fix Expired Pr…
d80c568 
…ograms Sort Issue] (#3921)

As a part of this PR, the query to retrieve the list of programs was
updated to ensure that the sort order of the retrieved list of programs
has the correct order where the inactive programs comprise the programs
that have `isActive = false` or the ones that have the `effectiveEndDate
<= CURRENT_DATE`
@ninosamson ninosamson reopened this Nov 18, 2024
@astridSABC astridSABC mentioned this issue Dec 6, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

@CarlyCotton CarlyCotton

Labels
Enhancement New feature or request Ministry Ministry Features
Projects
None yet
Milestone
2.X Post Part-Time Priorities
Development

No branches or pull requests
6 participants
@sh16011993 @ninosamson @andrewsignori-aot @Joshua-Lakusta @CarlyCotton @michesmith