#2741 - Ministry Filter Search Programs and Offerings [Fix Expired Programs Sort Issue] #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
changed the title
sh16011993
changed the title
sh16011993
commented
Nov 12, 2024
sources/packages/backend/apps/api/src/services/education-program/education-program.service.ts
Show resolved
Hide resolved
andrewsignori-aot
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Change looks and we should go ahead with it. The logic with the active and expiration is just something to be improved. Forcing it as a regular status just brings complexities that don`t feel worth it.
On the SQL command, there are SQL reserved worked in upper case and others in lower case.
We should try to stick with one or another IMO.=, not a blocker, hence approving.
| WHEN programs.programStatus = '${ProgramStatus.Approved}' and programs.isActive = true THEN ${SortPriority.Priority2} | ||
| WHEN programs.programStatus = '${ProgramStatus.Declined}' and programs.isActive = true THEN ${SortPriority.Priority3} | ||
| WHEN programs.isActive = false THEN ${SortPriority.Priority4} | ||
| WHEN programs.programStatus = '${ProgramStatus.Pending}' and programs.isActive = true and (programs.effectiveEndDate is null OR programs.effectiveEndDate > CURRENT_DATE) THEN ${SortPriority.Priority1} |
There was a problem hiding this comment.
Please remove the TODO comment.
andrepestana-aot
approved these changes
Nov 12, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
deleted the
2741_ministry_filter_search_programs_and_offerings_add_location_search_fix_expire_programs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the query to retrieve the list of programs was updated to ensure that the sort order of the retrieved list of programs has the correct order where the inactive programs comprise the programs that have
isActive = falseor the ones that have theeffectiveEndDate <= CURRENT_DATE