#2741 - Ministry Filter: Search Programs & Offerings [Data Table Conversion to Vuetify] #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted Prime Vue table to Vuetify Data Table
sh16011993
added
User Experience
sh16011993
changed the title
There was a problem hiding this comment.
Thanks for making the changes. Can you check if the server validation is working and review the below comment?
#3805 (comment)
Comment on lines
107
to
108
| rowsPerPage = DEFAULT_PAGE_LIMIT, | ||
| page = DEFAULT_DATATABLE_PAGE_NUMBER, |
There was a problem hiding this comment.
Please revert this twi line to avoid the Sonarcloud issue.
There was a problem hiding this comment.
I made those 2 as the last parameters. Does that work?
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Oct 22, 2024
andrepestana-aot
approved these changes
Oct 22, 2024
sh16011993
deleted the
2741_ministry_filter_search_programs_and_offerings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following task was completed:
Screenshots:
Added the loader while the data table loads:
Data table with data:
Data table without any records: