#2741 - Ministry Filter: Search Programs and Offerings [e2e tests] #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/packages/backend/libs/test-utils/src/utils/string-utils.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Show resolved
Hide resolved
| }, | ||
| ); | ||
|
|
||
| it( |
There was a problem hiding this comment.
This one would be a good candidate to have included a status sort desc to be validated.
There was a problem hiding this comment.
There is a problem testing this specific scenario here. The reason being that there are two Pending Program Status records and they can show up in any arbitrary order resulting in the test to fail arbitrarily.
There was a problem hiding this comment.
Fixed as discussed.
There was a problem hiding this comment.
I see the E2Es now having two scenarios with the sortOrder=ASC but the comment was suggesting one at least with the status sort desc. Was there any reason not to have it included in the scenarios?
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/test-utils/src/utils/string-utils.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ucation-program/_tests_/e2e/education-program.aest.controller.getProgramsSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
andrepestana-aot
approved these changes
Nov 5, 2024
…erings_add_location_search_e2e_tests
| @@ -56,6 +56,11 @@ | |||
| font: unset !important; | |||
| } | |||
|
|
|||
| // Temporary fix for Vuetify beta that does not display the selection component dropdown checkbox properly. | |||
There was a problem hiding this comment.
Is the comment required? Is the component still beta?
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
deleted the
2741_ministry_filter_search_programs_and_offerings_add_location_search_e2e_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following were completed:
EducationProgramAESTController(e2e)-getProgramsSummary
√ Should not retrieve any education programs when the search for the programs is made and no program statuses are searched for including no search for the inactive programs. (655 ms)
√ Should retrieve all the education programs when the search for the programs is made and all program statuses are searched for including the inactive programs. (385 ms)
√ Should retrieve all the inactive education programs when the search for the programs is made and none of the program statuses are selected except for the inactive programs. (359 ms)
√ Should retrieve all the pending, declined and inactive education programs sorted by ascending program status when the search for the programs is made and pending, declined program statuses are selected along with the inactive programs. (380 ms)
√ Should retrieve all the approved and declined education programs when the search for the programs is made and only the approved and declined program statuses are selected. (349 ms)
√ Should retrieve all the approved and pending education programs matching the program name search string when the search for the programs is made and the approved and pending program statuses are selected along with the program name search filter. (370 ms)
√ Should retrieve all the declined and inactive education programs sorted by ascending program status matching the program name search string and the location name search string when the search for the programs is made and the declined program status is selected along with the inactive programs selected and the program name and location name search filter. (623 ms)
Screenshot of the executed tests:
v-selectcomponent when the list item is unchecked.Issue:
Fix: