Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request an Offering Change - Submit/View UI - Validations and E2E test #2116

Closed
5 tasks done
andrewsignori-aot opened this issue Jul 14, 2023 · 0 comments
Closed
5 tasks done

Request an Offering Change - Submit/View UI - Validations and E2E test #2116

andrewsignori-aot opened this issue Jul 14, 2023 · 0 comments
Assignees
@ann-aot
Labels
Institution Institution Features
Milestone
2.0 Part-Time Stu...

Comments

@andrewsignori-aot
Copy link
Collaborator

andrewsignori-aot commented Jul 14, 2023 •
edited by ann-aot
Loading

Continuation of ticket #1954.

Acceptance Criteria

  • UI to allow study end date in the past and banner to be displayed as per Figma.
  • After submitting, redirect to the "In progress" tab. The tabs must be changed to be route based to allow the redirect back.
  • Ensure that API is executing the same validations from PIR. Try to centralize as much as possible the validations.
    • Selected offering belongs to the location (same as PIR).
    • Selected offering do not cause overlaps with other students' applications (SIMS, SFAS, same as PIR).
    • Offering intensity (apparently not checked for PIR but apparently was checked in the past because there is a related error const).
    • Offering belongs to the application program year (nice to have for this ticket). This validation is not currently in place for PIR (or even student application submission). It would be good to be added (not a must) or have another ticket created to ensure that it would be added.
  • Review PIR validations and follow the same rules.
  • E2E test
@andrewsignori-aot andrewsignori-aot added the Institution Institution Features label Jul 14, 2023
@andrewsignori-aot andrewsignori-aot mentioned this issue Jul 14, 2023
Closed
6 tasks
@ann-aot ann-aot self-assigned this Jul 19, 2023
ann-aot added a commit that referenced this issue Aug 9, 2023
@ann-aot
#2116 - Request an Offering Change - Submit/View UI - Validations (#2149
4734765 
)

#2116 - Request an Offering Change - Submit/View UI - Validations (#2149)
ann-aot added a commit that referenced this issue Aug 14, 2023
@ann-aot
#2116 - Request an Offering Change - E2E test (#2176)
a4ac1f3 
#2116 - Request an Offering Change - E2E test (#2176)
@michesmith michesmith added this to the 2.3 Student Start and Manage Financial Aid Application milestone Mar 12, 2024
@michesmith michesmith added this to the 2.0 Part-Time Students MVP milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ann-aot ann-aot

Labels
Institution Institution Features
Projects
None yet
Milestone
2.0 Part-Time Students MVP
Development

No branches or pull requests
3 participants
@andrewsignori-aot @ann-aot @michesmith