#1954 - Request an Offering Change - Submit/View UI (Part 1) #2105

andrewsignori-aot · 2023-07-11T21:42:06Z

Added a new endpoint to submit the request.
Added new endpoint to get the request details submitted: @Get(":applicationOfferingChangeRequestId")
Reused methods to load programs and offerings from PIR.
Created a component to display an offering summary to be used for the student offering change and with the potential to be used for scholastic standings and COE approvals.
Created a component to submit the requested change and visualize it.
- Method getEligibleApplications was reused to also retrieve the "change request"/"application details" to allow the submission. In this way, the same query constraints are used to load the summary list and also to get more details for the same item that will be submitted. New endpoint added as @Get("available/application/:applicationId").

Request a new offering change from the available applications.

Required validations

Submitted application in read-only mode

Approved application with StudentAid BC notes

Fixes and UI refactors

Fixed query for available applications that was showing the application available to report a change when there was one already in progress and also completed.
Removed extra space from detail-header after the label. Instead of showing label : value it will now show label: value.
Replace the "vertical divider" in detail-header with a pipe ("|") as per Figma.
Fixed the body-header #status-chip that was being displayed in the second line.

How the changed query looks like with the change.

SELECT
        "application"."id" AS "application_id",
        "application"."application_number" AS "application_application_number",
        "programYear"."id" AS "programYear_id",
        "currentAssessment"."id" AS "currentAssessment_id",
        "offering"."id" AS "offering_id",
        "offering"."study_start_date" AS "offering_study_start_date",
        "offering"."study_end_date" AS "offering_study_end_date",
        "offering"."offering_intensity" AS "offering_offering_intensity",
        "educationProgram"."id" AS "educationProgram_id",
        "student"."id" AS "student_id",
        "user"."first_name" AS "user_first_name",
        "user"."last_name" AS "user_last_name",
        "user"."id" AS "user_id"
FROM
        "sims"."applications" "application"
        INNER JOIN "sims"."program_years" "programYear" ON "programYear"."id" = "application"."program_year_id"
        INNER JOIN "sims"."student_assessments" "currentAssessment" ON "currentAssessment"."id" = "application"."current_assessment_id"
        INNER JOIN "sims"."education_programs_offerings" "offering" ON "offering"."id" = "currentAssessment"."offering_id"
        INNER JOIN "sims"."education_programs" "educationProgram" ON "educationProgram"."id" = "offering"."program_id"
        LEFT JOIN "sims"."application_offering_change_requests" "applicationOfferingChangeRequest" ON "applicationOfferingChangeRequest"."application_id" = "application"."id"
        AND (
                "applicationOfferingChangeRequest"."application_offering_change_request_status" IN ($ 1, $ 2)
        )
        INNER JOIN "sims"."students" "student" ON "student"."id" = "application"."student_id"
        INNER JOIN "sims"."users" "user" ON "user"."id" = "student"."user_id"
WHERE
        "applicationOfferingChangeRequest"."id" IS NULL
        AND "application"."location_id" = $ 3
        AND "application"."application_status" = $ 4
        AND "application"."is_archived" = false
ORDER BY
        "application_application_number" ASC
LIMIT
        10 -- PARAMETERS: ["In progress with SABC","In progress with student",12,"Completed"]

TODO

Centralize and apply similar validations from PIR.
Change tabs to allow routing navigation to allow the redirect to the "in progress" tab as per the AC.
E2E tests.

.../services/application-offering-change-request/application-offering-change-request.service.ts

...ation-offering-change-request/application-offering-change-request.institutions.controller.ts

.../services/application-offering-change-request/application-offering-change-request.service.ts

...ation-offering-change-request/application-offering-change-request.institutions.controller.ts

.../services/application-offering-change-request/application-offering-change-request.service.ts

dheepak-aot · 2023-07-12T19:03:38Z

...ation-offering-change-request/application-offering-change-request.institutions.controller.ts

+    @Param("locationId", ParseIntPipe) locationId: number,
+    @Body() payload: CreateApplicationOfferingChangeRequestAPIInDTO,
+  ): Promise<PrimaryIdentifierAPIOutDTO> {
+    // TODO: Apply the same validations from PIR.


...ation-offering-change-request/application-offering-change-request.institutions.controller.ts

dheepak-aot · 2023-07-12T19:10:03Z

...c/route-controllers/education-program-offering/education-program-offering.aest.controller.ts

@@ -185,7 +185,7 @@ export class EducationProgramOfferingAESTController extends BaseController {
  ): Promise<EducationProgramOfferingAPIOutDTO> {
    const offering = await this.programOfferingService.getOfferingById(
      offeringId,
-      true,
+      { isPrecedingOffering: true },


.../services/application-offering-change-request/application-offering-change-request.service.ts

...oute-controllers/education-program-offering/education-program-offering.controller.service.ts

...controllers/education-program-offering/education-program-offering.institutions.controller.ts

ann-aot

Added some comments

ann-aot · 2023-07-12T20:20:46Z

...ication-offering-change-request.institutions.controller.getCompletedApplications.e2e-spec.ts

Just 2 more point when I was running the branch in local, I found below things,
1.

, is the search box expected this way, I remember u saying it in our dev call.
2. In progress and completed tabs, the end date is missing, in the study dates

About number 1, I can create a common style to be applied to the search inputs in general and have a max-width associated with it. Thoughts? I will check to have it done maybe in an upcoming PR.

For item 2 I found an issue where the payload has an id property present it will replace the value. The fix was applied in the two tabs.

Iam good with it @andrewsignori-aot or else, as discussed we can create a small story for the style change

dheepak-aot · 2023-07-12T20:38:03Z

.../services/application-offering-change-request/application-offering-change-request.service.ts

      .leftJoin(
        "application.applicationOfferingChangeRequest",
        "applicationOfferingChangeRequest",
+        "applicationOfferingChangeRequest.applicationOfferingChangeRequestStatus IN (:...status)",


I get the point we discussed. 👍

guru-aot · 2023-07-12T22:09:46Z

...oute-controllers/education-program-offering/education-program-offering.controller.service.ts

+   */
+  async getOfferingById(
+    offeringId: number,
+    options?: {


Can we please remove optional for options?. As the one reference that is using it use options.

It is expected that the method will be consumed and also not provide the location id.
Please let me know if it would be considered a blocker.

NO its not a blocker, I saw there was only one reference so suggested the change.

sources/packages/web/src/services/ApplicationOfferingChangeRequestService.ts

guru-aot · 2023-07-12T22:30:55Z

sources/packages/backend/libs/sims-db/src/entities/application-offering-change-request.model.ts

@@ -14,7 +14,7 @@ import { User } from "./user.model";
 import { Note } from "./note.model";
 import { ApplicationOfferingChangeRequestStatus } from "./application-offering-change-request-status.type";

-const REASON_MAX_LENGTH = 500;
+export const REASON_MAX_LENGTH = 500;


dheepak-aot · 2023-07-12T22:35:52Z

Great work. Please have a look at the comments.

guru-aot

Done with a round of review, nice work @andrewsignori-aot

ann-aot

Thanks for doing the changes 👍 Good work with the component and the submit

.../services/application-offering-change-request/application-offering-change-request.service.ts

sonarqubecloud · 2023-07-13T01:02:21Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-07-13T01:03:09Z

Backend Unit Tests Coverage Report

Totals
Statements:	17.85% ( 2129 / 11927 )
Methods:	8.3% ( 126 / 1518 )
Lines:	20.64% ( 1865 / 9038 )
Branches:	10.07% ( 138 / 1371 )

github-actions · 2023-07-13T01:04:15Z

E2E Queue Consumers Coverage Report

Totals
Statements:	71% ( 399 / 562 )
Methods:	61.97% ( 44 / 71 )
Lines:	72.97% ( 351 / 481 )
Branches:	40% ( 4 / 10 )

github-actions · 2023-07-13T01:04:40Z

E2E Workflow Workers Coverage Report

Totals
Statements:	49.81% ( 267 / 536 )
Methods:	41.56% ( 32 / 77 )
Lines:	55.33% ( 218 / 394 )
Branches:	26.15% ( 17 / 65 )

github-actions · 2023-07-13T01:11:14Z

E2E SIMS API Coverage Report

Totals
Statements:	49.89% ( 3549 / 7113 )
Methods:	45.23% ( 417 / 922 )
Lines:	55.09% ( 2922 / 5304 )
Branches:	23.68% ( 210 / 887 )

guru-aot

LGTM,nice work @andrewsignori-aot

dheepak-aot

Thanks for making the changes. 👍

sh16011993

Nice work. LGTM 👍 @andrewsignori-aot

andrewsignori-aot added 4 commits July 5, 2023 14:56

Request offering change form

f0b36cd

Creating offering summary view component

cde8a6c

Created submit/view forms

382d35e

View form

1a6a810

andrewsignori-aot added Institution Web Portal SIMS-Api labels Jul 11, 2023

andrewsignori-aot self-assigned this Jul 11, 2023

andrewsignori-aot added 3 commits July 11, 2023 17:57

Refactor to use body-header-container

064395d

Fixed E2E tests

31af867

Comments improvements

00248d8

andrewsignori-aot marked this pull request as ready for review July 12, 2023 03:00

andrewsignori-aot requested review from ann-aot, dheepak-aot, sh16011993, hellolynn-tbtb, guru-aot and JasonCTang July 12, 2023 03:00

sh16011993 reviewed Jul 12, 2023

View reviewed changes

.../services/application-offering-change-request/application-offering-change-request.service.ts Show resolved Hide resolved

ann-aot reviewed Jul 12, 2023

View reviewed changes

...ation-offering-change-request/application-offering-change-request.institutions.controller.ts Show resolved Hide resolved