Document shard_count for go_test, and fix a few broken links#1361
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Mar 2, 2018
Merged
Document shard_count for go_test, and fix a few broken links#1361jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…ib#1382) This adds a changelog in a keepachanglog.com style format. It's initially populated with currently unreleased behavior and the last release's (0.24.0) changes. Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
This largely covers how to introduce a breaking change. It also attempts to clarify what is or isn't a breaking change. Closes bazel-contrib#1424 Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
This just writes down our support policies and puts them in a single location in the hosted docs. Summarized: * Bazel version support is as discussed from the maintainers meeting: upcoming, current, and last versions * Reference the Bazel rule compatibility guidelines (always having an incremental path to upgrade) * Described what experimental features mean. * Only support the latest rules_python version; older ones are best effort. * Only support platforms CI can run. Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Before this PR the users could not override how the hermetic toolchain is downloaded when in `bzlmod`. However, the same APIs would be available to users using `WORKSPACE`. With this we also allow root modules to restrict which toolchain versions the non-root modules, which may be helpful when optimizing the CI runtimes so that we don't waste time downloading multiple `micro` versions of the same `3.X` python version, which most of the times have identical behavior. Whilst at it, tweak the `semver` implementation to allow for testing of absence of values in the original input. Work towards bazel-contrib#2081 and this should be one of the last items that are blocking bazel-contrib#1361 from the API point of view. Replaces bazel-contrib#2151. --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…azel-contrib#2257) This avoids the tag being added when it doesn't need to be, which can look confusing to users without context about what it means. Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
This is documenting the current state and closing the last remaining TODO items for 1.0 release. Work towards bazel-contrib#1361. --------- Co-authored-by: Greg Roodt <groodt@gmail.com> Co-authored-by: Richard Levasseur <richardlev@gmail.com>
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…ontrib#2389) With this PR we are changing the defaults in the upcoming `0.39` version, and if all goes well, the release after that will be `1.0`. Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…azel-contrib#2406) Before this PR we would shell out to `uname` on UNIX systems to get the `arch` of the toolchain - on Windows we would not need to do it because there used to be only a single Windows platform. With this change we can correctly support the resolution of the python interpreter on various platforms and I have also added an env variable to customize the selection, so that users can use `musl` or a `freethreaded` interpreter if they wish. As part of this change, I have restricted visibility of the config settings used in the toolchain alias repo so that we are creating fewer targets. This is a very good time to do this before `1.0.0`. Fixes bazel-contrib#2145 Work towards bazel-contrib#2276 Work towards bazel-contrib#2386 Work towards bazel-contrib#1211 to unblock bazel-contrib#2402 Work towards bazel-contrib#1361 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Alternatives have existed for a long time and we just ensure that we remove before the 1.0 release. Summary: - remove pip_install_dependencies - remove DEFAULT_PYTHON_VERSION from interpreters.bzl Work towards bazel-contrib#1361
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…el-contrib#2407) Remove the deprecated symbol and use the default `pip` extension in `rules_python` to pull `twine` as part of the dependencies. Work towards bazel-contrib#1361 Fixes bazel-contrib#2268 for all the users by default
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Fixes bazel-contrib#1361 Closes bazel-contrib#2459 as won't do --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the functionality added in #1259.