Fix small typo and obsolete expressions.#2459
Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom Apr 27, 2020
Merged
Fix small typo and obsolete expressions.#2459jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod merged 2 commits intobazel-contrib:masterfrom
Conversation
* Fix typo in default value in `go_download_sdk` * Change "Skylark" to "Starlark" to meet current name
jayconrod
reviewed
Apr 27, 2020
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Fixes bazel-contrib#1361 Closes bazel-contrib#2459 as won't do --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go_download_sdkWhat type of PR is this?
Documentation
What does this PR do? Why is it needed?
Small typo and wrong expressions.
Which issues(s) does this PR fix?
Fixes #2458
Other notes for review