Slight clarification in strict dependencies error message#1424
Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom Apr 2, 2018
Merged
Slight clarification in strict dependencies error message#1424jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod merged 2 commits intobazel-contrib:masterfrom
Conversation
ianthehat
approved these changes
Apr 2, 2018
Collaborator
Author
|
I added another commit to print the known dependencies, too, so it's easier to tell what the mismatch is. PTAL. |
ianthehat
approved these changes
Apr 2, 2018
Contributor
ianthehat
left a comment
ianthehat
left a comment
There was a problem hiding this comment.
Might be a bit verbose if there are a lot of known dependancies, but it's probably not a problem worth solving.
Collaborator
Author
|
It would be nice to add a "did you mean" message after each missing import instead of listing all the known imports using edit distance. I'm not aware of a simple way to do that without going beyond the standard library. |
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
This largely covers how to introduce a breaking change. It also attempts to clarify what is or isn't a breaking change. Closes bazel-contrib#1424 Work towards bazel-contrib#1361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.