Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 27, 2023

Motivation and Context

This follows up from #4471 where old Signer was brought back, meaning clients were configured with both pre-SRA old Signer and SRA auth scheme resolution. With this change, adding a customization flag that codegen logic switches on to generate either old/new approach.

Modifications

Testing

see points above

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from zoewangg September 27, 2023 16:35
@gosar gosar marked this pull request as ready for review September 27, 2023 16:35
@gosar gosar requested a review from a team as a code owner September 27, 2023 16:35
To make the unit tests work for now. To make these work with
useSraAuth=false, it needs some codegen changes, which I'll make
separately.
To make the unit tests work for now. To make these work with
useSraAuth=false, it needs some codegen changes, which I'll make
separately.
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 448 Code Smells

84.4% 84.4% Coverage
3.9% 3.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit 8935502 into feature/master/sra-identity-auth Sep 27, 2023
@gosar gosar deleted the gosar/sra-ia-useSraAuth branch September 27, 2023 21:24
aws-sdk-java-automation added a commit that referenced this pull request Nov 13, 2025
…183b6bf0f

Pull request: release <- staging/f430b799-c7c4-499d-87d3-8b7183b6bf0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants