Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 28, 2023

Motivation and Context

This test broke after #4491 , since now the client was defaulting to useSraAuth=false.

Modifications

  • Add useSraAuth=true
  • Using the query service, as the restjson service was from codegen-resources/customresponsemetadata which seemed odd to use for this test. It doesn't really matter, but just switched to query, to use a vanilla service with no other customization.config.

Testing

./mvnw clean install -pl :codegen-generated-classes-test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar marked this pull request as ready for review September 28, 2023 07:41
@gosar gosar requested a review from a team as a code owner September 28, 2023 07:41
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 450 Code Smells

84.6% 84.6% Coverage
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit 26d88e2 into feature/master/sra-identity-auth Sep 28, 2023
@gosar gosar deleted the gosar/sra-ia-SraIdentityResolutionTest branch September 28, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants