Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Oct 3, 2023

Motivation and Context

Was switched to useSraAuth=true in e0e6a42 as part of #4491. Switching it back to false, like the rest of the feature/master/sra-identity-auth branch. New tests that were added earlier for useSraAuth=true have been disabled here. They should be enabled when we switch useSraAuth=true.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar marked this pull request as ready for review October 3, 2023 19:50
@gosar gosar requested a review from a team as a code owner October 3, 2023 19:50
@gosar gosar changed the title Switch endpointdiscovery back to useSraAuth=false Switch endpointdiscovery/endpointproviders back to useSraAuth=false Oct 3, 2023
@gosar gosar force-pushed the gosar/sra-ia-endpointdiscovery-false branch from d665f40 to e858018 Compare October 3, 2023 20:23
@gosar gosar force-pushed the gosar/sra-ia-endpointdiscovery-false branch from e858018 to fcf8f0b Compare October 3, 2023 22:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 492 Code Smells

85.1% 85.1% Coverage
4.4% 4.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit 847915e into feature/master/sra-identity-auth Oct 4, 2023
@gosar gosar deleted the gosar/sra-ia-endpointdiscovery-false branch October 4, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants