Skip to content

Remove legacy endpoint auth scheme logic and add putAuthScheme to AWS client builder. #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
millems merged 2 commits into from
Aug 23, 2023
Merged

Remove legacy endpoint auth scheme logic and add putAuthScheme to AWS client builder. #4311

millems merged 2 commits into from
Aug 23, 2023

Conversation

@millems
Copy link
Contributor

@millems millems commented Aug 15, 2023

Changes:

  • Move endpoint resolution header addition from EndpointAuthSchemeInterceptor to EndpointResolverInterceptor
  • Remove EndpointAuthSchemeInterceptor
  • When endpoint provider returns signer parameters, override parameters from the auth scheme provider
  • Add the ability to specify new or override existing auth schemes via putAuthScheme on AWS client builder.

@millems millems requested a review from a team as a code owner August 15, 2023 22:05
@millems millems force-pushed the millem/sra-endpoint-updates branch 2 times, most recently from d8ac1f4 to 85d2421 Compare August 15, 2023 23:13
@millems millems marked this pull request as draft August 15, 2023 23:17
@millems millems force-pushed the millem/sra-endpoint-updates branch 9 times, most recently from 680d7b7 to 2b73ab7 Compare August 22, 2023 23:44
@millems millems marked this pull request as ready for review August 22, 2023 23:46
millems added 2 commits August 23, 2023 14:58
@millems
Remove legacy endpoint auth scheme logic and add putAuthScheme to AWS…
e238b77 
… client builder.

Changes:
* Move endpoint resolution header addition from EndpointAuthSchemeInterceptor to EndpointResolverInterceptor
* Remove EndpointAuthSchemeInterceptor
* When endpoint provider returns signer parameters, override parameters from the auth scheme provider
* Add the ability to specify new or override existing auth schemes via putAuthScheme on AWS client builder.
* Speed up FlatteningSubscriberTest.stochastic_dataFlushedBeforeOnComplete
* Change endpoint-based auth scheme providers to use joinLikeSync instead of join to maintain exception backwards-compatibility.
@millems
Improve auth scheme map size.
c4890fd
@millems millems force-pushed the millem/sra-endpoint-updates branch from 2b73ab7 to c4890fd Compare August 23, 2023 22:15
@millems millems merged commit f4324fe into feature/master/sra-identity-auth Aug 23, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 265 Code Smells

0.0% 0.0% Coverage
2.6% 2.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar mentioned this pull request Aug 24, 2023
Merged
@gosar gosar mentioned this pull request Sep 27, 2023
Merged
12 tasks
gosar added a commit that referenced this pull request Sep 28, 2023
@gosar
Make s3 (mostly) work with preSRA
5f2bd5b 
This brings some of deleted codegen code related to endpoint rules
back from #4311. That PR
deleted the EndpointAuthSchemeInterceptor and put related logic in
EndpointResolverInterceptor. Not fully undoing that here, but logic
related to old Signer is brought back, now into
EndpointResolverInterceptor, when useSraAuth=false.

Now endpoints related tests in s3 pass, except for 3 tests related to
whether forward slash is added to endpoint. There's an existing TODO
related to that, so temporarily disabling it.
@gosar gosar mentioned this pull request Sep 28, 2023
Merged
12 tasks
gosar added a commit that referenced this pull request Sep 28, 2023
@gosar
Make s3 (mostly) work with preSRA
88064eb 
This brings some of deleted codegen code related to endpoint rules
back from #4311. That PR
deleted the EndpointAuthSchemeInterceptor and put related logic in
EndpointResolverInterceptor. Not fully undoing that here, but logic
related to old Signer is brought back, now into
EndpointResolverInterceptor, when useSraAuth=false.

Now endpoints related tests in s3 pass, except for 3 tests related to
whether forward slash is added to endpoint. There's an existing TODO
related to that, so temporarily disabling it.
gosar added a commit that referenced this pull request Sep 28, 2023
@gosar
Make s3 (mostly) work with preSRA (#4496)
b44d0a6 
* Add useSraAuth=true for SraIdentityResolutionTest

* Make s3control work with preSRA codegen

* Make s3 (mostly) work with preSRA

This brings some of deleted codegen code related to endpoint rules
back from #4311. That PR
deleted the EndpointAuthSchemeInterceptor and put related logic in
EndpointResolverInterceptor. Not fully undoing that here, but logic
related to old Signer is brought back, now into
EndpointResolverInterceptor, when useSraAuth=false.

Now endpoints related tests in s3 pass, except for 3 tests related to
whether forward slash is added to endpoint. There's an existing TODO
related to that, so temporarily disabling it.
@gosar gosar mentioned this pull request Sep 29, 2023
Merged
12 tasks
@millems millems deleted the millem/sra-endpoint-updates branch February 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joviegas joviegas joviegas approved these changes

@sugmanue sugmanue sugmanue approved these changes

+2 more reviewers

@haydenbaker haydenbaker haydenbaker left review comments

@cenedhryn cenedhryn cenedhryn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@millems @haydenbaker @cenedhryn @joviegas @sugmanue