Skip to content

Move settlement related apis from ExecutorApi and SystemDomainApi to SettlementApi#1497

Merged
vedhavyas merged 3 commits intomainfrom
refactor/settlement_api
Jun 7, 2023
Merged

Move settlement related apis from ExecutorApi and SystemDomainApi to SettlementApi#1497
vedhavyas merged 3 commits intomainfrom
refactor/settlement_api

Conversation

@vedhavyas
Copy link
Copy Markdown
Contributor

A refactoring PR that moves settlement related APIs from ExecutorApi and SystemDomainApi to SettlementApi.

Closes: #1493

Code contributor checklist:

NingLin-P
NingLin-P previously approved these changes Jun 6, 2023
Copy link
Copy Markdown
Contributor

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense overall!

liuchengxu
liuchengxu previously approved these changes Jun 6, 2023
@vedhavyas vedhavyas enabled auto-merge June 6, 2023 14:13
@nazar-pc nazar-pc disabled auto-merge June 7, 2023 12:57
@nazar-pc
Copy link
Copy Markdown
Member

nazar-pc commented Jun 7, 2023

There are merge conflicts here that need to be resolved

@vedhavyas vedhavyas dismissed stale reviews from NingLin-P and liuchengxu via 2138f29 June 7, 2023 13:08
@vedhavyas vedhavyas force-pushed the refactor/settlement_api branch from 5b02977 to 2138f29 Compare June 7, 2023 13:08
@vedhavyas vedhavyas requested review from NingLin-P and liuchengxu June 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge common functions from ExecutorApi and SystemDomainApi into SettlementAPI

4 participants