Prune the transaction from pool instead of removing it as invalid#1480
Merged
liuchengxu merged 1 commit intomainfrom May 31, 2023
Merged
Prune the transaction from pool instead of removing it as invalid#1480liuchengxu merged 1 commit intomainfrom
liuchengxu merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the existing usages of
remove_tx_from_tx_poolare to remove a ready transaction from the pool if I'm not wrong, this PR refactors it intoprune_tx_from_pool, removing such transactions usingprune_knowninstead of marking them as invalid and causing the same transaction banned.Close #1399
Code contributor checklist: