Conversation
nazar-pc
left a comment
There was a problem hiding this comment.
The explanation of the PR doesn't fully make sense to me. Yes, it needs to be wrapped and I changed the code to do that explicitly. Looks like I forgot ServerMessage::ProtocolRequest in one place? Then the fix would be a sincle line change rather than introduction of more generics and extra impls.
Not quite .. (I had explained this in more detail in the original PR probably). So we don't want the protocol layer to be aware of the This would be the simplest fix, than having more complex adapters full of generics, etc |
But you do have explicit impl that converts into |
bc0ae66 to
758895b
Compare
…improve-abstraction Improve abstraction a bit
Since all the messages hit the same server end point, they need to be wrapped in a common
enum. The changes from the last PR did not follow this requirement which causes decode failure. This PR fixes the issueCode contributor checklist: