Skip to content

Add cross domain message benchmark#1481

Merged
NingLin-P merged 13 commits intomainfrom
xdm-benchmark
Jun 6, 2023
Merged

Add cross domain message benchmark#1481
NingLin-P merged 13 commits intomainfrom
xdm-benchmark

Conversation

@NingLin-P
Copy link
Copy Markdown
Contributor

@NingLin-P NingLin-P commented Jun 1, 2023

close #1472

This PR implement #1472, it contains changes of:

  • Refactoring pallet-messenger to make it more benchmark friendly
    • Utilized the tx pool requires/provides tag to ensure xdm will be executed one by one in the channel nonce order, and remove our hand-crafted processing queue
    • Add weight tag to xdm to make it easier to inspect the consume weight of a xdm
  • Add test test_unordered_cross_domains_message_should_work to ensure the above changes work as expected
  • Add benchmark/weight to pallet-messenger and pallet-transporter

Code contributor checklist:

@NingLin-P NingLin-P requested review from liuchengxu and vedhavyas June 1, 2023 04:18
NingLin-P added 4 commits June 1, 2023 12:23
@NingLin-P
Utilized tx pool requires/provides tag to ensure xdm will be executed…
f2988d6 
… in channel nonce order

Similar to how account nonce is handled, this commit utilzed the tx pool processing queue
to ensure xdm will be executed one by one in the channel nonce order, and remove the need
needness of our hand-crafted processing queue.

Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Processing cross domain message one by one
d6eb24e 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Add weight tag to cross domain message
4dc60d5 
Message weight tag is used to indicate the consume weight when handling the message

Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Add message_weight/message_response_weight to EndpointHandler
d1a1130 
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P added 6 commits June 1, 2023 12:47
@NingLin-P
Add benchmarking for pallet-messenger
f27aac1 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Add benchmarking for pallet-transporter
7f7bc68 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Generate weight for pallet-messenger and pallet-transporter
6fa35c3 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Set up proper weight for pallet-messenger and pallet-transporter
363371f 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Add tes ttest_unordered_cross_domains_message_should_work
f543eaa 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Move xdm payload check to do_validate_relay_message and inbox fee cha…
84bb2a6 
…rging to pre_dispatch_relay_message

The xdm payload check should be check earlier in validate_unsigned while the
inbox fee charging should only take once thus need to be inside pre_dispatch

Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
vedhavyas reviewed Jun 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall make sense. Good work. Having said that, commits are not self contianed in the sense each commit should not give any compile time errors. First commit I believe is not compilable since the changes are introduced in second. Please add TODOs when the the change is temporary within the PR. This makes it easier to track.

@NingLin-P
Copy link
Copy Markdown
Contributor Author

NingLin-P commented Jun 5, 2023

Overall make sense. Good work. Having said that, commits are not self contianed in the sense each commit should not give any compile time errors. First commit I believe is not compilable since the changes are introduced in second. Please add TODOs when the the change is temporary within the PR. This makes it easier to track.

Sorry for the inconvenience here, I'm constructing these commits after all development is finished thus may forget some changes or pick the wrong changes into a commit, I will pay attention next time.

@NingLin-P
Apply review suggestions
834926b 
Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
vedhavyas reviewed Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Good to merge after 👍🏼

NingLin-P added 2 commits June 6, 2023 16:36
@NingLin-P
Fix typo
c1b0786 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
Merge branch 'main' into xdm-benchmark
03e8c0d
@NingLin-P NingLin-P enabled auto-merge June 6, 2023 08:38
@NingLin-P NingLin-P merged commit 0d3bda4 into main Jun 6, 2023
@NingLin-P NingLin-P deleted the xdm-benchmark branch June 6, 2023 11:22
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 22, 2023
@i1i1
Import autonomys/subspace#1476,autonomys/subspace#1480,autonomys/subs…
bc12635 
…pace#1489,autonomys/subspace#1489,autonomys/subspace#1477,autonomys/subspace#1481,autonomys/subspace#1496,autonomys/subspace#1497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@liuchengxu liuchengxu Awaiting requested review from liuchengxu

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extrinsic weight for cross domain message

2 participants

@NingLin-P @vedhavyas