EthConnector: make AdminControlled and pausable

[sept-en]

No description provided.

[birchmd]

This is looking pretty good to me so far!

[sept-en]

Btw, the CI is failing because of the internal Github Actions issue reported there.

[birchmd]

I wonder if it's worth trying to check specifically the error is raised because of the pause (e.g. by checking the error message), as opposed to some other reason. Just for the sake of completeness.

[sept-en]

Makes sense for me! It's worth adding the same for already existing tests there

[mrLSD]

We should change PausedMask logic to enum.

[mrLSD]

We discussed with @sept-en directly, so for now, the current implementation is pretty enough.

[sept-en]

As we internally discussed with @joshuajbouw @birchmd, we won't use bitflags crate at the current implementation (at least now). The initial idea was to improve the readability and improve the development experience, but we discovered that using this approach will require having additional boilerplate code for Borsh serialization/deserialization, make the AdminControlled trait very specific and not reusable in other possible components/repos. We also agreed that each dependency increases the risk from a security perspective, and it's better not to add additional dependencies if it's not crucial or doesn't give us significant improvements.

[birchmd]

LGTM nice work!