Eth connector statistic

[mrLSD]

Calculate total unique accounts.

Added method:

• get_accounts_counter

Covered with test

[birchmd]

Why is the value 2? I only see one call to deposit so I would only expect there to be one account.

[mrLSD]

Please look to that test:

#[test]
fn test_near_deposit_balance_total_supply() {
    let (master_account, contract) = init(CUSTODIAN_ADDRESS);
    call_deposit_near(&contract, CONTRACT_ACC);

    let balance = get_near_balance(&master_account, DEPOSITED_RECIPIENT, CONTRACT_ACC);
    assert_eq!(balance, DEPOSITED_AMOUNT - DEPOSITED_FEE);

    let balance = get_near_balance(&master_account, CONTRACT_ACC, CONTRACT_ACC);
    assert_eq!(balance, DEPOSITED_FEE);

[birchmd]

Right, there is a fee as well, so one deposit creates two accounts. Thanks for clarifying; it might be worth saying this in a comment as well.

Also, I recommend extending the test to have a transfer between those two accounts after the deposit, and confirm that the count does not change (because the number of unique accounts is the same).

[sept-en]

LGTM!
Still, let's put some attention to storage keys, otherwise, this could be quite confusing and hard to support later.

[birchmd]

Generally looks good to me. Please see my note about extending the test.

[birchmd]

Right, there is a fee as well, so one deposit creates two accounts. Thanks for clarifying; it might be worth saying this in a comment as well.

Also, I recommend extending the test to have a transfer between those two accounts after the deposit, and confirm that the count does not change (because the number of unique accounts is the same).