Skip to content

chore(warnings): fix compile warnings with latest dependencies - #3586

Merged
ellie merged 1 commit into
mainfrom
taylordotfish/fix-warnings
Jul 8, 2026
Merged

chore(warnings): fix compile warnings with latest dependencies#3586
ellie merged 1 commit into
mainfrom
taylordotfish/fix-warnings

Conversation

@taylordotfish

Copy link
Copy Markdown
Contributor

time::format_description::parse is deprecated in the latest version of time (used when the lockfile is ignored, as with cargo install atuin); replace with the recommended alternative. This change is compatible with the older version of time in the lockfile.

`time::format_description::parse` is deprecated in the latest version;
replace with the recommended alternative. This change is compatible with
the older version in the lockfile.
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fossier: Manual Review Requested

@taylordotfish is a new contributor. A maintainer should review this PR before merging.

Score Breakdown

Total Score: 59.9/100 | Confidence: 100% | Outcome: REVIEW

Signal Value Score Weight
account_age 2364 1.00 0.09
public_repos 74 1.00 0.05
contribution_history 76 0.38 0.05
follower_ratio 6.0 1.00 0.05
bot_signals False 0.50 0.04
open_prs_elsewhere 11 0.00 0.09
closed_prs_elsewhere 4 0.60 0.10
merged_prs_elsewhere 83 1.00 0.08
prior_interaction 1 0.33 0.08
activity_velocity 6 0.00 0.08
pr_content ... 1.00 0.08
commit_email contact@taylor.fish 0.80 0.04
pr_description ... 0.70 0.05
repo_stars 30470 0.30 0.04
org_membership 1 0.33 0.03
commit_verification ... 0.30 0.04
contributor_stars 472 1.00 0.04

@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes a deprecation warning by replacing time::format_description::parse with time::format_description::parse_borrowed::<1>, which is the recommended alternative in newer versions of the time crate.

  • The version const generic 1 matches the original format description syntax used in the format string, so the behavior is identical.
  • The change is backward-compatible with the time version pinned in the lockfile.

Confidence Score: 5/5

Minimal, correct deprecation fix with no behavioral change.

Single-line logic change that swaps a deprecated API for its direct replacement. The format string and its semantics are unchanged.

No files require special attention.

Important Files Changed

Filename Overview
crates/atuin/src/command/client/search/history_list.rs Replaces deprecated time::format_description::parse with parse_borrowed::<1> — correct migration, backward-compatible with the lockfile version.

Reviews (1): Last reviewed commit: "Fix compile warnings with latest depende..." | Re-trigger Greptile

@ellie ellie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ellie
ellie enabled auto-merge (squash) July 8, 2026 01:28
@ellie
ellie merged commit 2d975ee into main Jul 8, 2026
26 checks passed
@ellie
ellie deleted the taylordotfish/fix-warnings branch July 8, 2026 01:33
taylordotfish pushed a commit that referenced this pull request Jul 9, 2026
### Bug Fixes

- *(ai)* Dispatch skills registered in the slash command registry
([#3593](#3593))
- *(ci)* Fossier install in scan workflow
([#3485](#3485))
- *(i18n)* Fix typos in Russian localization
([#3575](#3575))
- *(nu)* Use `char -u 1b` for ESC in OSC 133 sequences
([#3530](#3530))
- *(nu)* Suppress error when `ATUIN_HISTORY_ID` is missing in
`pre_prompt` hook
([#3587](#3587))
- *(pi)* Observe tool events instead of registering a bash tool
([#3557](#3557))
- *(pty-proxy)* Set `$SHELL` to the spawned shell
([#3548](#3548))
- *(search)* Fix terminal clearing with latest Ratatui
([#3578](#3578))
- *(sync)* Skip records that fail to decrypt or decode instead of
failing the whole store
([#3569](#3569))
- Atuin hangs when attempting to spawn daemon from Ctrl+R invocation
([#3502](#3502))
- Capture session ID from stream headers rather than final event
([#3531](#3531))
- Doctor resiliency fo runknown platforms + openbsd warning
([#3551](#3551))
- Double input on arrow keys in AI setup prompt on Windows
([#3552](#3552))
- Exclude AI agent commands from zsh-autosuggestions
([#3567](#3567))
- Silence shellcheck SC2016 on literal `$all-user` author filter
- Respect `store_failed` when using daemon
([#3571](#3571))


### Documentation

- Highlight `Ctrl-r` keybinding on docs page
([#3489](#3489))
- Document store purge workflow
([#3544](#3544))
- Fix command example typo in documentation
([#3536](#3536))
- Make commented-out lines in `config.toml` match real defaults
([#3583](#3583))
- Add fish shell cleanup step to uninstall instructions
([#3582](#3582))


### Features

- *(doctor)* Add whether daemon is enabled to `doctor` output
([#3572](#3572))
- *(pty-proxy)* Add `--shell` flag to override the spawned shell
([#3327](#3327))
- Setup fossier to stop bot slop prs
([#3482](#3482))
- Capture command output + expose to new `atuin_output` tool
([#3510](#3510))
- Cache user contexts on load until `/reload`
([#3525](#3525))
- Create database integration tests for atuin-server
([#3514](#3514))
- Add `/model` slash command for changing models
([#3576](#3576))
- Add mcp server for history tools and expand search filters
([#3581](#3581))
- Add status bar with model and usage information
([#3591](#3591))


### Miscellaneous Tasks

- *(rustdoc)* Fix Rustdoc warnings
([#3585](#3585))
- *(warnings)* Fix compile warnings with latest dependencies
([#3586](#3586))
- Vouch for all existing contributors
([#3486](#3486))
- Update GitHub app token format
- Update to Rust 1.96.1
([#3568](#3568))
- Adopt `derive_more` to reduce boilerplate across the codebase
([#3573](#3573))


### Performance

- *(search)* Scan history by recency until N unique
([#3553](#3553))
- Add `synchronous(Normal)` + `optimize_on_close` to record store SQLite
([#3577](#3577))
- Remove unnecessary clones in a hot path
([#3580](#3580))


### Refactor

- Implement `From<sqlx::Error>` and clean up `fix_error`
([#3484](#3484))
- Pull `fn into_utc` into `atuin-server-database` crate
([#3487](#3487))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants