Skip to content

feat(doctor): add whether daemon is enabled to doctor output - #3572

Merged
ellie merged 1 commit into
mainfrom
taylordotfish/doctor-daemon
Jul 7, 2026
Merged

feat(doctor): add whether daemon is enabled to doctor output#3572
ellie merged 1 commit into
mainfrom
taylordotfish/doctor-daemon

Conversation

@taylordotfish

Copy link
Copy Markdown
Contributor

Add whether the daemon is enabled to the output of atuin doctor.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Fossier: Manual Review Requested

@taylordotfish is a new contributor. A maintainer should review this PR before merging.

Score Breakdown

Total Score: 63.9/100 | Confidence: 100% | Outcome: REVIEW

Signal Value Score Weight
account_age 2363 1.00 0.09
public_repos 74 1.00 0.05
contribution_history 76 0.38 0.05
follower_ratio 6.0 1.00 0.05
bot_signals False 0.50 0.04
open_prs_elsewhere 10 0.00 0.09
closed_prs_elsewhere 4 0.60 0.10
merged_prs_elsewhere 79 1.00 0.08
prior_interaction 1 0.33 0.08
activity_velocity 2 0.67 0.08
pr_content ... 0.85 0.08
commit_email contact@taylor.fish 0.80 0.04
pr_description ... 0.70 0.05
repo_stars 30464 0.30 0.04
org_membership 1 0.33 0.03
commit_verification ... 0.30 0.04
contributor_stars 472 1.00 0.04

@greptile-apps

greptile-apps Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a daemon_enabled field to the AtuinInfo struct used by atuin doctor, exposing whether the daemon is active in diagnostic output.

  • The field is computed as cfg!(feature = "daemon") && settings.daemon.enabled, correctly reflecting both compile-time feature availability and runtime configuration.

Confidence Score: 5/5

Minimal, additive change to a diagnostic command — no behavioral risk.

One new struct field and one line of initialization, both straightforward and correct. No existing behavior is altered.

No files require special attention.

Important Files Changed

Filename Overview
crates/atuin/src/command/client/doctor.rs Adds daemon_enabled field to AtuinInfo, correctly gating on both the compile-time feature flag and the runtime setting.

Reviews (1): Last reviewed commit: "Add whether daemon is enabled to doctor ..." | Re-trigger Greptile

@ellie ellie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaya ty! :shipit:

@ellie
ellie merged commit 2d54aff into main Jul 7, 2026
26 checks passed
@ellie
ellie deleted the taylordotfish/doctor-daemon branch July 7, 2026 19:11
taylordotfish pushed a commit that referenced this pull request Jul 9, 2026
### Bug Fixes

- *(ai)* Dispatch skills registered in the slash command registry
([#3593](#3593))
- *(ci)* Fossier install in scan workflow
([#3485](#3485))
- *(i18n)* Fix typos in Russian localization
([#3575](#3575))
- *(nu)* Use `char -u 1b` for ESC in OSC 133 sequences
([#3530](#3530))
- *(nu)* Suppress error when `ATUIN_HISTORY_ID` is missing in
`pre_prompt` hook
([#3587](#3587))
- *(pi)* Observe tool events instead of registering a bash tool
([#3557](#3557))
- *(pty-proxy)* Set `$SHELL` to the spawned shell
([#3548](#3548))
- *(search)* Fix terminal clearing with latest Ratatui
([#3578](#3578))
- *(sync)* Skip records that fail to decrypt or decode instead of
failing the whole store
([#3569](#3569))
- Atuin hangs when attempting to spawn daemon from Ctrl+R invocation
([#3502](#3502))
- Capture session ID from stream headers rather than final event
([#3531](#3531))
- Doctor resiliency fo runknown platforms + openbsd warning
([#3551](#3551))
- Double input on arrow keys in AI setup prompt on Windows
([#3552](#3552))
- Exclude AI agent commands from zsh-autosuggestions
([#3567](#3567))
- Silence shellcheck SC2016 on literal `$all-user` author filter
- Respect `store_failed` when using daemon
([#3571](#3571))


### Documentation

- Highlight `Ctrl-r` keybinding on docs page
([#3489](#3489))
- Document store purge workflow
([#3544](#3544))
- Fix command example typo in documentation
([#3536](#3536))
- Make commented-out lines in `config.toml` match real defaults
([#3583](#3583))
- Add fish shell cleanup step to uninstall instructions
([#3582](#3582))


### Features

- *(doctor)* Add whether daemon is enabled to `doctor` output
([#3572](#3572))
- *(pty-proxy)* Add `--shell` flag to override the spawned shell
([#3327](#3327))
- Setup fossier to stop bot slop prs
([#3482](#3482))
- Capture command output + expose to new `atuin_output` tool
([#3510](#3510))
- Cache user contexts on load until `/reload`
([#3525](#3525))
- Create database integration tests for atuin-server
([#3514](#3514))
- Add `/model` slash command for changing models
([#3576](#3576))
- Add mcp server for history tools and expand search filters
([#3581](#3581))
- Add status bar with model and usage information
([#3591](#3591))


### Miscellaneous Tasks

- *(rustdoc)* Fix Rustdoc warnings
([#3585](#3585))
- *(warnings)* Fix compile warnings with latest dependencies
([#3586](#3586))
- Vouch for all existing contributors
([#3486](#3486))
- Update GitHub app token format
- Update to Rust 1.96.1
([#3568](#3568))
- Adopt `derive_more` to reduce boilerplate across the codebase
([#3573](#3573))


### Performance

- *(search)* Scan history by recency until N unique
([#3553](#3553))
- Add `synchronous(Normal)` + `optimize_on_close` to record store SQLite
([#3577](#3577))
- Remove unnecessary clones in a hot path
([#3580](#3580))


### Refactor

- Implement `From<sqlx::Error>` and clean up `fix_error`
([#3484](#3484))
- Pull `fn into_utc` into `atuin-server-database` crate
([#3487](#3487))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants