Skip to content

Exclude AI agent commands from zsh-autosuggestions - #3567

Merged
ellie merged 1 commit into
atuinsh:mainfrom
brianhelba:patch-1
Jul 7, 2026
Merged

Exclude AI agent commands from zsh-autosuggestions#3567
ellie merged 1 commit into
atuinsh:mainfrom
brianhelba:patch-1

Conversation

@brianhelba

Copy link
Copy Markdown
Contributor

Without this, commands from AI agents will pollute the suggestions passed to zsh-autosuggestions (which is used by live users).

This touches the same code as #2903, but this PR should be a less controversial simple bugfix.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fossier: Vouched and Approved

@ellie vouched for @brianhelba. Future PRs from this contributor will be trusted.

@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds --author '$all-user' to the atuin search call inside _zsh_autosuggest_strategy_atuin so that AI agent commands are excluded from zsh-autosuggestion completions. The $all-user sentinel is documented in the CLI as filtering to non-agent entries, and single-quoting is correct to pass it as a literal string rather than a shell variable.

  • Single-line change to atuin.zsh: appends --author '$all-user' to the prefix-search used by zsh-autosuggestions.

Confidence Score: 5/5

Safe to merge — a minimal, focused one-line change with no side effects on existing behaviour.

The change is a single flag addition to one command, the sentinel value is documented in the CLI source, and the shell quoting is correct. No regressions are expected.

No files require special attention.

Important Files Changed

Filename Overview
crates/atuin/src/shell/atuin.zsh Adds --author '$all-user' to the autosuggestion search call to exclude AI agent commands; single-quoting is correct to pass the literal sentinel to atuin.

Reviews (1): Last reviewed commit: "Exclude AI agent commands from zsh-autos..." | Re-trigger Greptile

@ellie ellie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thank you!!

@ellie

ellie commented Jul 7, 2026

Copy link
Copy Markdown
Member

/fossier vouch

@ellie
ellie merged commit df6ec6c into atuinsh:main Jul 7, 2026
25 of 26 checks passed
@brianhelba
brianhelba deleted the patch-1 branch July 7, 2026 04:31
taylordotfish pushed a commit that referenced this pull request Jul 9, 2026
### Bug Fixes

- *(ai)* Dispatch skills registered in the slash command registry
([#3593](#3593))
- *(ci)* Fossier install in scan workflow
([#3485](#3485))
- *(i18n)* Fix typos in Russian localization
([#3575](#3575))
- *(nu)* Use `char -u 1b` for ESC in OSC 133 sequences
([#3530](#3530))
- *(nu)* Suppress error when `ATUIN_HISTORY_ID` is missing in
`pre_prompt` hook
([#3587](#3587))
- *(pi)* Observe tool events instead of registering a bash tool
([#3557](#3557))
- *(pty-proxy)* Set `$SHELL` to the spawned shell
([#3548](#3548))
- *(search)* Fix terminal clearing with latest Ratatui
([#3578](#3578))
- *(sync)* Skip records that fail to decrypt or decode instead of
failing the whole store
([#3569](#3569))
- Atuin hangs when attempting to spawn daemon from Ctrl+R invocation
([#3502](#3502))
- Capture session ID from stream headers rather than final event
([#3531](#3531))
- Doctor resiliency fo runknown platforms + openbsd warning
([#3551](#3551))
- Double input on arrow keys in AI setup prompt on Windows
([#3552](#3552))
- Exclude AI agent commands from zsh-autosuggestions
([#3567](#3567))
- Silence shellcheck SC2016 on literal `$all-user` author filter
- Respect `store_failed` when using daemon
([#3571](#3571))


### Documentation

- Highlight `Ctrl-r` keybinding on docs page
([#3489](#3489))
- Document store purge workflow
([#3544](#3544))
- Fix command example typo in documentation
([#3536](#3536))
- Make commented-out lines in `config.toml` match real defaults
([#3583](#3583))
- Add fish shell cleanup step to uninstall instructions
([#3582](#3582))


### Features

- *(doctor)* Add whether daemon is enabled to `doctor` output
([#3572](#3572))
- *(pty-proxy)* Add `--shell` flag to override the spawned shell
([#3327](#3327))
- Setup fossier to stop bot slop prs
([#3482](#3482))
- Capture command output + expose to new `atuin_output` tool
([#3510](#3510))
- Cache user contexts on load until `/reload`
([#3525](#3525))
- Create database integration tests for atuin-server
([#3514](#3514))
- Add `/model` slash command for changing models
([#3576](#3576))
- Add mcp server for history tools and expand search filters
([#3581](#3581))
- Add status bar with model and usage information
([#3591](#3591))


### Miscellaneous Tasks

- *(rustdoc)* Fix Rustdoc warnings
([#3585](#3585))
- *(warnings)* Fix compile warnings with latest dependencies
([#3586](#3586))
- Vouch for all existing contributors
([#3486](#3486))
- Update GitHub app token format
- Update to Rust 1.96.1
([#3568](#3568))
- Adopt `derive_more` to reduce boilerplate across the codebase
([#3573](#3573))


### Performance

- *(search)* Scan history by recency until N unique
([#3553](#3553))
- Add `synchronous(Normal)` + `optimize_on_close` to record store SQLite
([#3577](#3577))
- Remove unnecessary clones in a hot path
([#3580](#3580))


### Refactor

- Implement `From<sqlx::Error>` and clean up `fix_error`
([#3484](#3484))
- Pull `fn into_utc` into `atuin-server-database` crate
([#3487](#3487))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants