Skip to content

Update Python version for pyupgrade in pre-commit#2190

Merged
tatiana merged 3 commits into
mainfrom
pyupgrade_update
Dec 9, 2025
Merged

Update Python version for pyupgrade in pre-commit#2190
tatiana merged 3 commits into
mainfrom
pyupgrade_update

Conversation

@pankajastro
Copy link
Copy Markdown
Contributor

@pankajastro pankajastro commented Dec 8, 2025

This PR modernizes the codebase to use Python 3.10+ syntax by updating the pyupgrade pre-commit hook configuration from --py37-plus to --py310-plus. The changes primarily involve migrating type imports from the typing module to collections.abc for runtime-checkable types and using built-in generic types.

Key changes:

  • Updated pyupgrade configuration in .pre-commit-config.yaml to target Python 3.10+
  • Migrated runtime-checkable types (Generator, Callable, Sequence, Iterator, AsyncIterator) from typing to collections.abc
  • Replaced Type[...] with type[...] and List with list for type annotations

@pankajastro pankajastro marked this pull request as ready for review December 8, 2025 16:16
Copilot AI review requested due to automatic review settings December 8, 2025 16:16
@pankajastro pankajastro marked this pull request as draft December 8, 2025 16:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the codebase to use Python 3.10+ syntax by updating the pyupgrade pre-commit hook configuration from --py37-plus to --py310-plus. The changes primarily involve migrating type imports from the typing module to collections.abc for runtime-checkable types and using built-in generic types.

Key changes:

  • Updated pyupgrade configuration in .pre-commit-config.yaml to target Python 3.10+
  • Migrated runtime-checkable types (Generator, Callable, Sequence, Iterator, AsyncIterator) from typing to collections.abc
  • Replaced Type[...] with type[...] and List with list for type annotations

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.pre-commit-config.yaml Updated pyupgrade argument from --py37-plus to --py310-plus
tests/perf/test_performance.py Migrated Generator import from typing to collections.abc
tests/dbt/parser/test_project.py Removed List import and replaced with built-in list
docs/generate_mappings.py Replaced Type with built-in type for type annotations
cosmos/profiles/__init__.py Replaced Type with built-in type for type annotations
cosmos/plugin/airflow3.py Migrated Generator import from typing to collections.abc
cosmos/operators/watcher.py Migrated Callable import from typing to collections.abc
cosmos/operators/virtualenv.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/local.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/kubernetes.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/gcp_cloud_run_job.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/docker.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/base.py Migrated Sequence import from typing to collections.abc
cosmos/operators/azure_container_instance.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/aws_eks.py Migrated Sequence import from typing to collections.abc
cosmos/operators/aws_ecs.py Migrated Callable and Sequence imports from typing to collections.abc
cosmos/operators/_watcher/state.py Migrated Callable import from typing to collections.abc
cosmos/operators/_asynchronous/bigquery.py Migrated Sequence import from typing to collections.abc
cosmos/hooks/subprocess.py Migrated Callable import from typing to collections.abc
cosmos/dbt/runner.py Migrated Callable import from typing to collections.abc
cosmos/dbt/project.py Migrated Generator import from typing to collections.abc
cosmos/converter.py Migrated Callable import from typing to collections.abc
cosmos/constants.py Migrated Callable import from typing to collections.abc
cosmos/config.py Migrated Callable and Iterator imports from typing to collections.abc
cosmos/airflow/graph.py Migrated Callable import from typing to collections.abc
cosmos/_utils/importer.py Migrated Callable import from typing to collections.abc
cosmos/_triggers/watcher.py Migrated AsyncIterator import from typing to collections.abc

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pankajastro pankajastro marked this pull request as ready for review December 8, 2025 16:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.85%. Comparing base (768513d) to head (6d025d4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2190   +/-   ##
=======================================
  Coverage   97.84%   97.85%           
=======================================
  Files          94       94           
  Lines        6038     6058   +20     
=======================================
+ Hits         5908     5928   +20     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much, @pankajastro !

@tatiana tatiana merged commit f7892d8 into main Dec 9, 2025
90 checks passed
@tatiana tatiana deleted the pyupgrade_update branch December 9, 2025 12:50
@pankajkoti pankajkoti mentioned this pull request Dec 9, 2025
tatiana added a commit that referenced this pull request Dec 12, 2025
I incorrectly closed #2185, thinking that the `- --py310-plus` syntax
used in #2190 was `pre-commit`, not pyupgrade specific.

This PR aims to allow anyone using `Python versions => 3.10` to be able
to run `pre-commit`, while failing if a previous version is used.
pankajkoti added a commit that referenced this pull request Dec 18, 2025
Breaking changes

* Introduced in the PR #2080. The following functions are expected to be
used internally only to Cosmos, so we hope these won't impact end-users,
but we are documenting the changes just in case:
- ``generate_task_or_group`` receives ``render_config`` instead of its
individual configurations, such as ``test_behavior``,
``source_rendering_behavior`` and ``enable_owner_inheritance``
- ``create_task_metadata`` receives ``render_config`` instead of its
individual configurations, such as ``test_behavior``,
``source_rendering_behavior`` and ``enable_owner_inheritance``
- ``create_task_metadata`` now expects the ``node_converters`` argument
* Drop Python 3.9 support by @pankajastro in #2118
* Drop Airflow 2.4 support by @pankajastro in #2161
* Drop Airflow 2.5 support by @pankajastro in #2165

Features

* Support applying ``node_converter`` at a task level instead of task
group level by @anyapriya in #1759
* Allow overriding ``DbtProducerWatcherOperator`` parameters via
``ExecutionConfig.setup_operator_args`` by @pankajastro in #2133
* Use deferrable sensors by default in ``ExecutionMode.WATCHER`` by
@pankajastro in #2084
* Support real-time consumer updates when using
``ExecutionMode.WATCHER`` and ``InvocationMode.SUBPROCESS`` by
@pankajastro in #2152
* Update telemetry to v3 format with query parameters by @pankajkoti in
#2192
* Add initial set of telemetry task listener metrics for Cosmos
operators by @pankajkoti in #2195

Enhancements

* Unify Airflow version handling into ``constants.py`` by @tatiana in
#2089
* Refactor ``airflow/graph.py`` to simplify the code base by @tatiana in
#2080
* Force watcher producer retries to zero by @pankajkoti in #2114
* Fail ``ExecutionMode.WATCHER`` consumer sensors immediately when the
producer fails using Airflow context by @pankajkoti in #2126
* ``ExecutonMode.WATCHER``: fetch producer status asynchronously from
the Airflow runtime so deferrable sensors fail immediately when the
producer task fails by @pankajkoti in #2144
* Refactor ``ExecutionMode.WATCHER`` ``InvocationMode.SUBPROCESS`` log
parser by @tatiana in #2183
* Replace map_index with is_mapped_task boolean in task telemetry
metrics by @pankajkoti in #2210
* Collect cosmos profile metrics in task telemetry metrics by
@pankajastro in #2198
* Remove unnecessary information from telemetry by @tatiana in #2211

Bug fixes

* Clarify ``ExecutionMode.WATCHER`` deferrable failure messaging by
@pankajkoti in #2124
* Remove empty test tasks when all tests are detached by @anyapriya in
#2010
* Fix forwarding ``DbtProducerWatcherOperator`` ``dbt build`` flags by
@michal-mrazek in #2127
* Add databricks oauth mock profile by @fjmacagno in #2164
* Register listeners in Airflow 3 plugin implementation by @pankajastro
in #2187
* Fix resolution of ``packages-install-path`` when it uses ``env_var``
by @tatiana in #2194
* Fix ``template_fields`` in ``DbtConsumerWatcherSensor`` to include
``DbtRunLocalOperator`` template_fields`` by @tiovader and @emanuel-luis
in #2209
* Emit asset events in ExecutionMode.AIRFLOW_ASYNC mode by @pankajastro
in #2184
* Remove dag_run_id from telemetry tests by @tatiana in #2213

Docs

* Document dataset-event limitation when using
``ExecutionMode.AIRFLOW_ASYNC`` by @varaprasadregani in #2143
* Expand ``ExecutionMode.KUBERNETES`` guidance by @tatiana  in #2139
* Add docs for deferrable ``DbtConsumerWatcherSensor`` by @pankajastro
in #2115
* Fix reStructuredText formatting by @dnskr in #2132
* Add docs for ``setup_operator_args`` param by @pankajastro in #2136
* Remove experimental flag for ``ExecutionMode.AIRFLOW_ASYNC`` by
@pankajastro in #2153
* Clarify ``ExecutionMode.AIRFLOW_ASYNC`` dataset limits by @pankajkoti
in #2167
* Update PRIVACY_NOTICE.rst by @tatiana in #2212

Others

* Drop Python 3.9 support by @pankajastro in #2118
* Drop Airflow 2.4 support by @pankajastro in #2161
* Drop Airflow 2.5 support by @pankajastro in #2165
* Improve example DAG ``jaffle_shop_kubernetes.py`` by @tatiana in #2140
* Enable tests for Python 3.13 by @pankajastro in #2154
* Add Python 3.12 to CI integration tests matrix by @pankajastro in
#2168
* Retry flaky Telemetry success test to stabilise CI by @pankajkoti in
#2138
* Drop unused producer state xcom handling in ``ExecutionMode.WATCHER``
by @pankajkoti in #2145
* Remove unused Python3.9 uses from Github action CI by @pankajastro in
#2117
* Run pre-commit on ``ExecutionMode.WATCHER`` modules by @pankajkoti in
#2150
* Refactor: Use shared airflow version constant by @pankajkoti in #2157
* Pin ``pydantic<2.0`` for Airflow 2.6 compatibility by @pankajastro in
#2172
* Remove duplicate ``dbt-duckdb`` dependency by @pankajastro in #2170
* Add targeted ``type: ignore`` for untyped decorators to fix ``mypy``
errors by @pankajastro in #2174
* Replace Legacy typing Aliases with Built-in Types for Python 3.10+ by
@pankajastro in #2175
* Refactor to reuse ``load_method_from_module`` from
``_utils/importer.py`` by @pankajastro in #2176
* Remove try except block for cache import and unused python_version
variable by @pankajastro in #2186
* Unpin Airflow to satisfy GitHub Security tab requirements by
@pankajastro in #2171
* Update Python version for ``pyupgrade`` in ``pre-commit`` config by
@pankajastro in #2190
* Add cooldown config in ``dependabot`` config by @pankajastro in #2189
* Adjust pre-commit so Python 3.10 or higher can be used by @tatiana in
#2196
* Remove empty variables emission from telemetry metrics by @pankajkoti
in #2197
* Reformat documented comments for historical URL formats by @pankajkoti
in #2199
* Bump ``actions/checkout`` from ``5.0.0`` to ``5.0.1`` by @dependabot
in #2135
* Bump ``actions/checkout`` to ``6.0.0`` in GitHub workflows by
@dependabot in #2147
* Bump ``zizmorcore/zizmor-action`` from ``0.2.0`` to ``0.3.0`` by
@dependabot in #2156
* Bump ``actions/checkout`` from ``5.0.1`` to ``6.0.0`` by @dependabot
in #2155
* Bump ``actions/checkout`` from ``6.0.0`` to ``6.0.1`` by @dependabot
in #2178
* Bump ``codecov/codecov-action`` from ``5.5.1`` to ``5.5.2`` by
@dependabot in #2208
* pre-commit autoupdate by @pre-commit-ci[bot] in #2134, #2162, #2173,
#2191, #2202

closes:
astronomer/oss-integrations-private#275
@tatiana tatiana added this to the Cosmos 1.12.0 milestone Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants