Skip to content

Remove unused Python3.9 uses from Github action CI#2117

Merged
tatiana merged 3 commits into
mainfrom
clean3.9
Nov 12, 2025
Merged

Remove unused Python3.9 uses from Github action CI#2117
tatiana merged 3 commits into
mainfrom
clean3.9

Conversation

@pankajastro
Copy link
Copy Markdown
Contributor

This PR clean unused Python3.9 uses from Github action CI

Copilot AI review requested due to automatic review settings November 12, 2025 12:59
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 12, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit 5166136
🔍 Latest deploy log https://app.netlify.com/projects/sunny-pastelito-5ecb04/deploys/691485f9872d9e00081c3aef

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a redundant Python 3.9 exclusion from the GitHub Actions CI test matrix. The exclusion was preventing the Python 3.9 + Airflow 2.7 combination from being tested, but since Python 3.9 is not included in the test matrix to begin with, this exclusion entry serves no purpose.

  • Removed Python 3.9 with Airflow 2.7 exclusion entry from the test matrix
  • Removed associated comment explaining the temporary nature of the exclusion
Comments suppressed due to low confidence (1)

.github/workflows/test.yml:57

  • Python 3.9 is declared as a supported version in pyproject.toml (line 11: requires-python = \">=3.9\", line 24 classifier, and line 170 in hatch test matrix) but is not included in the CI test matrix. Consider either adding Python 3.9 to the test matrix or removing it from the supported versions in pyproject.toml to align the project's stated support with actual testing coverage.
        python-version: ["3.10", "3.11", "3.12"]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test.yml Outdated
Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did we remove Python 3.9 support..? My understanding is that we agreed to not do this change for now: #2035. I discussed with @yetudada and she was happy for us to continue support Python 3.9 for now as well. The Python 3.9 are the fastest tests to run in our CI and they have not caused mantainance overhead, so I'd like to see them being re-added.

@tatiana
Copy link
Copy Markdown
Collaborator

tatiana commented Nov 12, 2025

I just saw it was removed by mistake in this PR:
a9fca6a#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88

We should re-add it, and skip it only for the latest versions of Airflow that don't support it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (b58778b) to head (5166136).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          92       92           
  Lines        5961     5961           
=======================================
  Hits         5831     5831           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pankajkoti
Copy link
Copy Markdown
Contributor

On the contrary, I agree with @pankajastro's thoughts in comment. My opinion is that we should be aggressive on dropping dbt and Python versions that have reached their EOL.

@tatiana
Copy link
Copy Markdown
Collaborator

tatiana commented Nov 12, 2025

I just checked the two utilisation sources we have, Astro Cloud customers, and Scarf. And I agree for us to remove Python 3.9 support.

The main reasoning:

  • We currently have 0.4% of Astro customers who have Cosmos installed using Python 3.9.
  • Within the Scarf data, we see the top 10 python_version utilised, and all of them are Python 3.10 or higher

More details in the slack discussion.

@tatiana tatiana merged commit fa645d8 into main Nov 12, 2025
85 checks passed
@tatiana tatiana deleted the clean3.9 branch November 12, 2025 14:01
Copy link
Copy Markdown
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro I believe it's important that we highlight in our user facing docs and Changelog that starting Cosmos 1.12.0 we're dropping support for Python 3.9. Would be nice if you could add a PR for the same when possible.

@pankajastro
Copy link
Copy Markdown
Contributor Author

@pankajastro I believe it's important that we highlight in our user facing docs and Changelog that starting Cosmos 1.12.0 we're dropping support for Python 3.9. Would be nice if you could add a PR for the same when possible.

yes, created followup PR: #2118

@tatiana tatiana added this to the Cosmos 1.12.0 milestone Nov 13, 2025
pankajastro added a commit that referenced this pull request Nov 13, 2025
Based on the discussion in [PR
#2117](#2117), we
are officially dropping support for Python 3.9 from the main branch.
Python 3.9 support will be removed starting with Cosmos v1.12.0.
@pankajkoti pankajkoti mentioned this pull request Nov 21, 2025
pankajkoti added a commit that referenced this pull request Dec 18, 2025
Breaking changes

* Introduced in the PR #2080. The following functions are expected to be
used internally only to Cosmos, so we hope these won't impact end-users,
but we are documenting the changes just in case:
- ``generate_task_or_group`` receives ``render_config`` instead of its
individual configurations, such as ``test_behavior``,
``source_rendering_behavior`` and ``enable_owner_inheritance``
- ``create_task_metadata`` receives ``render_config`` instead of its
individual configurations, such as ``test_behavior``,
``source_rendering_behavior`` and ``enable_owner_inheritance``
- ``create_task_metadata`` now expects the ``node_converters`` argument
* Drop Python 3.9 support by @pankajastro in #2118
* Drop Airflow 2.4 support by @pankajastro in #2161
* Drop Airflow 2.5 support by @pankajastro in #2165

Features

* Support applying ``node_converter`` at a task level instead of task
group level by @anyapriya in #1759
* Allow overriding ``DbtProducerWatcherOperator`` parameters via
``ExecutionConfig.setup_operator_args`` by @pankajastro in #2133
* Use deferrable sensors by default in ``ExecutionMode.WATCHER`` by
@pankajastro in #2084
* Support real-time consumer updates when using
``ExecutionMode.WATCHER`` and ``InvocationMode.SUBPROCESS`` by
@pankajastro in #2152
* Update telemetry to v3 format with query parameters by @pankajkoti in
#2192
* Add initial set of telemetry task listener metrics for Cosmos
operators by @pankajkoti in #2195

Enhancements

* Unify Airflow version handling into ``constants.py`` by @tatiana in
#2089
* Refactor ``airflow/graph.py`` to simplify the code base by @tatiana in
#2080
* Force watcher producer retries to zero by @pankajkoti in #2114
* Fail ``ExecutionMode.WATCHER`` consumer sensors immediately when the
producer fails using Airflow context by @pankajkoti in #2126
* ``ExecutonMode.WATCHER``: fetch producer status asynchronously from
the Airflow runtime so deferrable sensors fail immediately when the
producer task fails by @pankajkoti in #2144
* Refactor ``ExecutionMode.WATCHER`` ``InvocationMode.SUBPROCESS`` log
parser by @tatiana in #2183
* Replace map_index with is_mapped_task boolean in task telemetry
metrics by @pankajkoti in #2210
* Collect cosmos profile metrics in task telemetry metrics by
@pankajastro in #2198
* Remove unnecessary information from telemetry by @tatiana in #2211

Bug fixes

* Clarify ``ExecutionMode.WATCHER`` deferrable failure messaging by
@pankajkoti in #2124
* Remove empty test tasks when all tests are detached by @anyapriya in
#2010
* Fix forwarding ``DbtProducerWatcherOperator`` ``dbt build`` flags by
@michal-mrazek in #2127
* Add databricks oauth mock profile by @fjmacagno in #2164
* Register listeners in Airflow 3 plugin implementation by @pankajastro
in #2187
* Fix resolution of ``packages-install-path`` when it uses ``env_var``
by @tatiana in #2194
* Fix ``template_fields`` in ``DbtConsumerWatcherSensor`` to include
``DbtRunLocalOperator`` template_fields`` by @tiovader and @emanuel-luis
in #2209
* Emit asset events in ExecutionMode.AIRFLOW_ASYNC mode by @pankajastro
in #2184
* Remove dag_run_id from telemetry tests by @tatiana in #2213

Docs

* Document dataset-event limitation when using
``ExecutionMode.AIRFLOW_ASYNC`` by @varaprasadregani in #2143
* Expand ``ExecutionMode.KUBERNETES`` guidance by @tatiana  in #2139
* Add docs for deferrable ``DbtConsumerWatcherSensor`` by @pankajastro
in #2115
* Fix reStructuredText formatting by @dnskr in #2132
* Add docs for ``setup_operator_args`` param by @pankajastro in #2136
* Remove experimental flag for ``ExecutionMode.AIRFLOW_ASYNC`` by
@pankajastro in #2153
* Clarify ``ExecutionMode.AIRFLOW_ASYNC`` dataset limits by @pankajkoti
in #2167
* Update PRIVACY_NOTICE.rst by @tatiana in #2212

Others

* Drop Python 3.9 support by @pankajastro in #2118
* Drop Airflow 2.4 support by @pankajastro in #2161
* Drop Airflow 2.5 support by @pankajastro in #2165
* Improve example DAG ``jaffle_shop_kubernetes.py`` by @tatiana in #2140
* Enable tests for Python 3.13 by @pankajastro in #2154
* Add Python 3.12 to CI integration tests matrix by @pankajastro in
#2168
* Retry flaky Telemetry success test to stabilise CI by @pankajkoti in
#2138
* Drop unused producer state xcom handling in ``ExecutionMode.WATCHER``
by @pankajkoti in #2145
* Remove unused Python3.9 uses from Github action CI by @pankajastro in
#2117
* Run pre-commit on ``ExecutionMode.WATCHER`` modules by @pankajkoti in
#2150
* Refactor: Use shared airflow version constant by @pankajkoti in #2157
* Pin ``pydantic<2.0`` for Airflow 2.6 compatibility by @pankajastro in
#2172
* Remove duplicate ``dbt-duckdb`` dependency by @pankajastro in #2170
* Add targeted ``type: ignore`` for untyped decorators to fix ``mypy``
errors by @pankajastro in #2174
* Replace Legacy typing Aliases with Built-in Types for Python 3.10+ by
@pankajastro in #2175
* Refactor to reuse ``load_method_from_module`` from
``_utils/importer.py`` by @pankajastro in #2176
* Remove try except block for cache import and unused python_version
variable by @pankajastro in #2186
* Unpin Airflow to satisfy GitHub Security tab requirements by
@pankajastro in #2171
* Update Python version for ``pyupgrade`` in ``pre-commit`` config by
@pankajastro in #2190
* Add cooldown config in ``dependabot`` config by @pankajastro in #2189
* Adjust pre-commit so Python 3.10 or higher can be used by @tatiana in
#2196
* Remove empty variables emission from telemetry metrics by @pankajkoti
in #2197
* Reformat documented comments for historical URL formats by @pankajkoti
in #2199
* Bump ``actions/checkout`` from ``5.0.0`` to ``5.0.1`` by @dependabot
in #2135
* Bump ``actions/checkout`` to ``6.0.0`` in GitHub workflows by
@dependabot in #2147
* Bump ``zizmorcore/zizmor-action`` from ``0.2.0`` to ``0.3.0`` by
@dependabot in #2156
* Bump ``actions/checkout`` from ``5.0.1`` to ``6.0.0`` by @dependabot
in #2155
* Bump ``actions/checkout`` from ``6.0.0`` to ``6.0.1`` by @dependabot
in #2178
* Bump ``codecov/codecov-action`` from ``5.5.1`` to ``5.5.2`` by
@dependabot in #2208
* pre-commit autoupdate by @pre-commit-ci[bot] in #2134, #2162, #2173,
#2191, #2202

closes:
astronomer/oss-integrations-private#275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants