chore(core): Implement Protobuf trait for tx actions#1320
Merged
ethanoroshiba merged 3 commits intomainfrom Aug 1, 2024
Merged
chore(core): Implement Protobuf trait for tx actions#1320ethanoroshiba merged 3 commits intomainfrom
ethanoroshiba merged 3 commits intomainfrom
Conversation
Fraser999
approved these changes
Aug 1, 2024
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
One minor, non-blocking comment.
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
steezeburger
added a commit
that referenced
this pull request
Aug 2, 2024
* main: chore(core): Implement Protobuf trait for tx actions (#1320) refactor(sequencer): remove global state (#1317) refactor(sequencer): move asset state methods to asset module (#1313) feat(sequencer, core): Add fee reporting (#1305) chore(bridge-withdrawer): cleanup nonce handling (#1292) fix(charts, bridge): fix ci test (#1310)
ethanoroshiba
added a commit
that referenced
this pull request
Aug 2, 2024
## Summary Implemented the `Protobuf` trait for all TX `Action`s and variants. ## Background `Action` and variants are refined types from generated Protobuf code, but did not implement the `Protobuf` trait. This change is to standardize the types `Error` and `Raw` across `Action`, as well as the methods `to_raw()`, `into_raw()`, `try_from_raw()`, and `try_from_raw_ref()`. ## Changes - Implemented `Protobuf` trait, types, and necessary functions for `Action` and all of its variants. - Deleted redundant functions which took ownership, but kept those which prioritized cost over their `ref` counterparts. ## Testing Passing all tests. ## Related Issues closes #1307 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
ethanoroshiba
added a commit
that referenced
this pull request
Aug 13, 2024
## Summary Implemented the `Protobuf` trait for all TX `Action`s and variants. ## Background `Action` and variants are refined types from generated Protobuf code, but did not implement the `Protobuf` trait. This change is to standardize the types `Error` and `Raw` across `Action`, as well as the methods `to_raw()`, `into_raw()`, `try_from_raw()`, and `try_from_raw_ref()`. ## Changes - Implemented `Protobuf` trait, types, and necessary functions for `Action` and all of its variants. - Deleted redundant functions which took ownership, but kept those which prioritized cost over their `ref` counterparts. ## Testing Passing all tests. ## Related Issues closes #1307 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
ethanoroshiba
added a commit
that referenced
this pull request
Aug 14, 2024
## Summary Implemented the `Protobuf` trait for all TX `Action`s and variants. ## Background `Action` and variants are refined types from generated Protobuf code, but did not implement the `Protobuf` trait. This change is to standardize the types `Error` and `Raw` across `Action`, as well as the methods `to_raw()`, `into_raw()`, `try_from_raw()`, and `try_from_raw_ref()`. ## Changes - Implemented `Protobuf` trait, types, and necessary functions for `Action` and all of its variants. - Deleted redundant functions which took ownership, but kept those which prioritized cost over their `ref` counterparts. ## Testing Passing all tests. ## Related Issues closes #1307 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the
Protobuftrait for all TXActions and variants.Background
Actionand variants are refined types from generated Protobuf code, but did not implement theProtobuftrait. This change is to standardize the typesErrorandRawacrossAction, as well as the methodsto_raw(),into_raw(),try_from_raw(), andtry_from_raw_ref().Changes
Protobuftrait, types, and necessary functions forActionand all of its variants.refcounterparts.Testing
Passing all tests.
Related Issues
closes #1307