Conversation
joroshiba
commented
Jul 29, 2024
| {{ if tag != '' { replace('--set evm-rollup.images.conductor.devTag=# --set composer.images.composer.devTag=#', '#', tag) } else { '' } }} \ | ||
| --set blockscout-stack.enabled=false \ | ||
| --set postgresql.enabled=false \ | ||
| --set evm-bridge-withdrawer.enabled=false \ |
Member
Author
There was a problem hiding this comment.
this is in the cli test, it shouldn't be running the bridge withdrawer
joroshiba
commented
Jul 29, 2024
| repository: "file://../evm-faucet" | ||
| condition: evm-faucet.enabled | ||
| - name: bridge-withdrawer | ||
| - name: evm-bridge-withdrawer |
Member
Author
There was a problem hiding this comment.
Our overrides were over the wrong chart sha in tests. The name here wasn't following norms, the name here should match the chart name, fixed the chart instead of just changing values overrides.
joroshiba
commented
Jul 29, 2024
| .wrap_err_with(|| { | ||
| format!("failed to connect to sequencer at `{sequencer_grpc_endpoint}`") | ||
| })?; | ||
| let sequencer_client = SequencerServiceClient::connect(sequencer_grpc_endpoint.clone()) |
Member
Author
There was a problem hiding this comment.
We shouldn't be forcing http on the url path here, uri protocol specified in the env var.
joroshiba
requested review from
SuperFluffy,
noot and
steezeburger
and removed request for
noot
SuperFluffy
approved these changes
Jul 30, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Rust is correct. I could have sworn I flagged this in a review, but maybe forgot.
This should be refactored so that there is a single point of failure when constructing this client. I will create a follow-up.
steezeburger
approved these changes
Jul 30, 2024
github-actions
bot
added
the
ci
steezeburger
added a commit
that referenced
this pull request
Aug 2, 2024
* main: chore(core): Implement Protobuf trait for tx actions (#1320) refactor(sequencer): remove global state (#1317) refactor(sequencer): move asset state methods to asset module (#1313) feat(sequencer, core): Add fee reporting (#1305) chore(bridge-withdrawer): cleanup nonce handling (#1292) fix(charts, bridge): fix ci test (#1310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bridge withdrawer code which was broken + CI test setup issue which allowed broken test to get in.
Background
We were not using the latest bridge withdrawer code correctly, this fixes that + fixes the code which broke main CI tests