refactor(sequencer): move asset state methods to asset module#1313
Merged
SuperFluffy merged 2 commits intomainfrom Aug 1, 2024
Merged
refactor(sequencer): move asset state methods to asset module#1313SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
Fraser999
approved these changes
Aug 1, 2024
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
LGTM, but a couple of non-blocking nitpicks.
joroshiba
approved these changes
Aug 1, 2024
Member
joroshiba
left a comment
joroshiba
left a comment
There was a problem hiding this comment.
approving the snapshot relocate updates
steezeburger
added a commit
that referenced
this pull request
Aug 2, 2024
* main: chore(core): Implement Protobuf trait for tx actions (#1320) refactor(sequencer): remove global state (#1317) refactor(sequencer): move asset state methods to asset module (#1313) feat(sequencer, core): Add fee reporting (#1305) chore(bridge-withdrawer): cleanup nonce handling (#1292) fix(charts, bridge): fix ci test (#1310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved methods for manipulating state assets to the state asset module.
Background
Sequencer uses the convention of having state setters and writers as methods in a trait
<component>::StateReadExtand<component>::StateWriteExt. For example, a sudo address (which lives in the authority module) can be read withauthority::StateReadExt::get_sudo_address. The exception to this are the methods for manipulating assets, which were underastria_sequencer::state_ext::StateExt. This is because the asset module was just recently introduced.Changes
No business logic was changed in this patch!
crate::asset -> crate::assetsastria_sequencer::state_ext::State{Read,Write}Exttoastria_sequencer::assets::State{Read,Write}Ext.State{Read,Write}Extfrom all parent modules so that one can writeuse <component>::StateReadExt(and similar for write) instead ofuse <component>::state_ext::StateReadExt.Testing
No tests were changed (minus import paths). Asset-related tests were moved (including snapshot tests)
Related Issues
Closes #1312