feat(sequencer, core): Add fee reporting#1305
Merged
ethanoroshiba merged 11 commits intomainfrom Jul 30, 2024
Merged
Conversation
ethanoroshiba
changed the title
Fraser999
reviewed
Jul 29, 2024
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
Generally looks good, but I made a few nitpicky suggestions :)
SuperFluffy
reviewed
Jul 29, 2024
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
…astria into eoroshiba/report_fees
Fraser999
approved these changes
Jul 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
## Summary Added event recording for fees on `Transfer` and `Sequence` actions. ## Background Fees were previously not reported, and since Astria doesn't fill out gas wanted/used on `ExecTxResult`, there was no outside way of viewing a block or transaction's associated fees. ## Changes - Added `get_action_type()` methods to `TransferAction` and `SequencerAction` to facilitate passing the kind of action to `get_and_increase_block_fees()`. - Added construction and recording of ABCI events having kind `tx.fees` and attributes `asset`, `feeAmount`, and `actionType`. ## Testing Added unit test to ensure `tx.fees` event is recorded correctly in the transaction state events. ## Related Issues closes #1293 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
steezeburger
added a commit
that referenced
this pull request
Aug 2, 2024
* main: chore(core): Implement Protobuf trait for tx actions (#1320) refactor(sequencer): remove global state (#1317) refactor(sequencer): move asset state methods to asset module (#1313) feat(sequencer, core): Add fee reporting (#1305) chore(bridge-withdrawer): cleanup nonce handling (#1292) fix(charts, bridge): fix ci test (#1310)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added event recording for fees on
TransferandSequenceactions.Background
Fees were previously not reported, and since Astria doesn't fill out gas wanted/used on
ExecTxResult, there was no outside way of viewing a block or transaction's associated fees.Changes
get_action_type()methods toTransferActionandSequencerActionto facilitate passing the kind of action toget_and_increase_block_fees().tx.feesand attributesasset,feeAmount, andactionType.Testing
Added unit test to ensure
tx.feesevent is recorded correctly in the transaction state events.Related Issues
closes #1293