refactor(bridge-withdrawer): move generated contract bindings to crate#1237
Merged
SuperFluffy merged 3 commits intomainfrom Jul 8, 2024
Merged
refactor(bridge-withdrawer): move generated contract bindings to crate#1237SuperFluffy merged 3 commits intomainfrom
SuperFluffy merged 3 commits intomainfrom
Conversation
github-actions
bot
added
the
ci
SuperFluffy
force-pushed
the
superfluffy/generate-contract-code
branch
3 times, most recently
from
6ad4f01 to
1e76af3
Compare
SuperFluffy
force-pushed
the
superfluffy/generate-contract-code
branch
from
1e76af3 to
986947a
Compare
Fraser999
approved these changes
Jul 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
steezeburger
added a commit
that referenced
this pull request
Jul 11, 2024
* main: (27 commits) refactor(sequencer): fix prepare proposal metrics (#1211) refactor(bridge-withdrawer): move generated contract bindings to crate (#1237) fix(sequencer) fix wrong metric and remove unused metric (#1240) feat(sequencer): implement transaction fee query (#1196) chore(cli)!: remove unmaintained rollup subcommand (#1235) release(sequencer): 0.14.1 patch release (#1233) feat(sequencer-utils): generate example genesis state (#1224) feat(sequencer): implement abci query for bridge account info (#1189) feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141) chore(charts): update for new geth update (#1226) chore(chart)!: dusk-8 chart version updates (#1223) release(conductor): fix conductor release version (#1222) release: dusk-8 versions (#1219) fix(core): revert `From` ed25519_consensus types for crypto mod (#1220) Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193) refactor(withdrawer): read from block subscription stream and get events on each block (#1207) feat(core): implement with verification key for address builder and crypto improvements (#1218) feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209) chore(chart): update evm chart for new prefix field (#1214) chore: bump penumbra deps (#1216) ...
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
#1237) ## Summary Moves the generated Rust bindings for Astria's bridge smart contracts to a free standing crate. ## Background Breaking out the bindings outside the `astria-bridge-withdrawer` binary crate is needed to share code with a CLI tool to manually initiate withdrawals. This patch also uses the opportunity and makes the process of re-generating bindings (and committing them to the repo) more similar to how protobuf-bindings are generated: `tools/solidity-compiler` updates the git submodule in `astria-bridge-contracts` and then regenerates all bindings. The bindings are placed in `astria-bridge-contracts/src/generated` and commited to the repository. ## Changes - Create `crates/astria-bridge-contracts` crate and move the submodule of the same name there - Create `tools/solidity-compiler` tool and use it to generate rust bindings for the bridge contracts - Update `astria-bridge-withdrawer` to use `astria-bridge-contracts` as a dependency - Add a job `solidity-contracts-compiled` to ensure that the contracts are up-to-date. ## Testing Apart from some types being renamed, nothing has changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the generated Rust bindings for Astria's bridge smart contracts to a free standing crate.
Background
Breaking out the bindings outside the
astria-bridge-withdrawerbinary crate is needed to share code with a CLI tool to manually initiate withdrawals.This patch also uses the opportunity and makes the process of re-generating bindings (and committing them to the repo) more similar to how protobuf-bindings are generated:
tools/solidity-compilerupdates the git submodule inastria-bridge-contractsand then regenerates all bindings. The bindings are placed inastria-bridge-contracts/src/generatedand commited to the repository.Changes
crates/astria-bridge-contractscrate and move the submodule of the same name theretools/solidity-compilertool and use it to generate rust bindings for the bridge contractsastria-bridge-withdrawerto useastria-bridge-contractsas a dependencysolidity-contracts-compiledto ensure that the contracts are up-to-date.Testing
Apart from some types being renamed, nothing has changed.