Skip to content

feat(sequencer-utils): generate example genesis state#1224

Merged
SuperFluffy merged 4 commits intomainfrom
superfluffy/genesis-state-to-core
Jul 3, 2024
Merged

feat(sequencer-utils): generate example genesis state#1224
SuperFluffy merged 4 commits intomainfrom
superfluffy/genesis-state-to-core

Conversation

@SuperFluffy
Copy link
Contributor

Summary

Provides a generate-genesis-state subcommand to sequencer-utils.

Background

We had a test-genesis.json file committed to the repo that was not checked to be in-sync with the most recent version of sequencer's actual GenesisState. The subcommand generate-genesis-state removes the need to keep the file in sync because one can always generate one that matches the current format.

Changes

  • remove astria-sequencer/test-genesis-app-state.json
  • move sequencer's GenesisState to the new astria-core::sequencer submodule. Because this config is effectively a public API, it is justified to be outside of the astria-sequencer binary crate.

Testing

It is a very thin binary which can be run by hand. The specific format of GenesisState not changing is ensured by a snapshot test that was moved from astria-sequencer to astria-core.

Related Issues

Closes #1212

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Jun 28, 2024
@SuperFluffy SuperFluffy force-pushed the superfluffy/genesis-state-to-core branch 3 times, most recently from 8c0cc9f to 3eb33bd Compare June 28, 2024 11:01
@SuperFluffy SuperFluffy marked this pull request as ready for review June 28, 2024 11:25
@SuperFluffy SuperFluffy requested review from a team, joroshiba and noot as code owners June 28, 2024 11:25
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the astria-sequencer justfile run-cometbft command as well? otherwise, looks good!

@SuperFluffy
Copy link
Contributor Author

can you update the astria-sequencer justfile run-cometbft command as well? otherwise, looks good!

I have updated the justfile to make that work, but I think we should think about creating a more actively maintained solution to starting a test-network of sequencers.

@SuperFluffy SuperFluffy requested a review from noot July 3, 2024 12:55
@SuperFluffy SuperFluffy added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@SuperFluffy SuperFluffy added this pull request to the merge queue Jul 3, 2024
@SuperFluffy SuperFluffy removed this pull request from the merge queue due to a manual request Jul 3, 2024
@SuperFluffy SuperFluffy force-pushed the superfluffy/genesis-state-to-core branch from cece566 to b8b8a87 Compare July 3, 2024 16:32
@SuperFluffy SuperFluffy enabled auto-merge July 3, 2024 16:32
@SuperFluffy SuperFluffy added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit e3e7548 Jul 3, 2024
@SuperFluffy SuperFluffy deleted the superfluffy/genesis-state-to-core branch July 3, 2024 16:44
steezeburger added a commit that referenced this pull request Jul 11, 2024
* main: (27 commits)
  refactor(sequencer): fix prepare proposal metrics (#1211)
  refactor(bridge-withdrawer): move generated contract bindings to crate (#1237)
  fix(sequencer) fix wrong metric and remove unused metric (#1240)
  feat(sequencer): implement transaction fee query (#1196)
  chore(cli)!: remove unmaintained rollup subcommand (#1235)
  release(sequencer): 0.14.1 patch release (#1233)
  feat(sequencer-utils): generate example genesis state (#1224)
  feat(sequencer): implement abci query for bridge account info (#1189)
  feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141)
  chore(charts): update for new geth update (#1226)
  chore(chart)!: dusk-8 chart version updates (#1223)
  release(conductor): fix conductor release version (#1222)
  release: dusk-8 versions (#1219)
  fix(core): revert `From` ed25519_consensus types for crypto mod (#1220)
  Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193)
  refactor(withdrawer): read from block subscription stream and get events on each block (#1207)
  feat(core): implement with verification key for address builder and crypto improvements (#1218)
  feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209)
  chore(chart): update evm chart for new prefix field (#1214)
  chore: bump penumbra deps (#1216)
  ...
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
## Summary
Provides a `generate-genesis-state` subcommand to sequencer-utils.

## Background
We had a `test-genesis.json` file committed to the repo that was not
checked to be in-sync with the most recent version of sequencer's actual
`GenesisState`. The subcommand `generate-genesis-state` removes the need
to keep the file in sync because one can always generate one that
matches the current format.

## Changes
- remove `astria-sequencer/test-genesis-app-state.json`
- move sequencer's `GenesisState` to the new `astria-core::sequencer`
submodule. Because this config is effectively a public API, it is
justified to be outside of the `astria-sequencer` binary crate.

## Testing
It is a very thin binary which can be run by hand. The specific format
of `GenesisState` not changing is ensured by a snapshot test that was
moved from `astria-sequencer` to `astria-core`.

## Related Issues
Closes #1212

---------

Co-authored-by: noot <36753753+noot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sequencer pertaining to the astria-sequencer crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sequencer: local testing file test-genesis-app-state.json is brittle

2 participants