feat(charts): bridge-withdrawer, smoke test, various chart improvements#1141
Merged
feat(charts): bridge-withdrawer, smoke test, various chart improvements#1141
Conversation
github-actions
bot
added
ci
joroshiba
force-pushed
the
joroshiba/withdrawal-helm-chart
branch
from
322c64c to
92415fc
Compare
joroshiba
force-pushed
the
joroshiba/withdrawal-helm-chart
branch
from
92415fc to
f3cf610
Compare
joroshiba
force-pushed
the
joroshiba/withdrawal-helm-chart
branch
from
f3cf610 to
fa341d3
Compare
joroshiba
force-pushed
the
joroshiba/withdrawal-helm-chart
branch
from
fa341d3 to
04c609b
Compare
joroshiba
force-pushed
the
joroshiba/withdrawal-helm-chart
branch
from
4b01138 to
9da90ab
Compare
joroshiba
dismissed stale reviews from SuperFluffy, aajimal, noot, and steezeburger
major changes since
quasystaty1
reviewed
Jul 2, 2024
quasystaty1
reviewed
Jul 2, 2024
quasystaty1
approved these changes
Jul 2, 2024
SuperFluffy
approved these changes
Jul 2, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Approving the query path renaming. That was my oversight.
Sidenote: that abci query will likely return ibc-prefixed denoms right now. That's probably somewhat questionable for the users and might be changed to return the full trace-prefixed denoms in the future (we make no guarantees for this and changing it will not be a breaking).
| .insert( | ||
| "asset/allowed_fee_asset_ids", | ||
| crate::asset::query::allowed_fee_asset_ids_request, | ||
| "asset/allowed_fee_assets", |
Contributor
There was a problem hiding this comment.
To confirm our offline discussion: this change is correct, just overlooked this in the big refactor to remove IDs
steezeburger
added a commit
that referenced
this pull request
Jul 11, 2024
* main: (27 commits) refactor(sequencer): fix prepare proposal metrics (#1211) refactor(bridge-withdrawer): move generated contract bindings to crate (#1237) fix(sequencer) fix wrong metric and remove unused metric (#1240) feat(sequencer): implement transaction fee query (#1196) chore(cli)!: remove unmaintained rollup subcommand (#1235) release(sequencer): 0.14.1 patch release (#1233) feat(sequencer-utils): generate example genesis state (#1224) feat(sequencer): implement abci query for bridge account info (#1189) feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141) chore(charts): update for new geth update (#1226) chore(chart)!: dusk-8 chart version updates (#1223) release(conductor): fix conductor release version (#1222) release: dusk-8 versions (#1219) fix(core): revert `From` ed25519_consensus types for crypto mod (#1220) Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193) refactor(withdrawer): read from block subscription stream and get events on each block (#1207) feat(core): implement with verification key for address builder and crypto improvements (#1218) feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209) chore(chart): update evm chart for new prefix field (#1214) chore: bump penumbra deps (#1216) ...
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ts (#1141) ## Summary Adds the bridge withdrawer chart, updates smoke test to use it, improves the release process of charts, and has a slew of other chart upgrades to bring most of charts closer to same standard. ## Background We want to make sure the bridge withdrawal path works across changes, need chart for running in production. ## Changes - fix sequencer query which was not updated with change to asset from asset id - Add an `evm-bridge-withdrawer` helm chart - Update smoke test to utilize bridge withdrawer path - Update `deploy.just` to default to using the deployed bridge and have init commands. - Improve the release process of charts to [astriaorg/charts](https://github.com/astriaorg/charts). Now includes the README from `/charts` and the `/dev` directory so you can utilize just the charts repo for lighter weight deployment. - Update charts to have liveness, startup, and readyness probes where appropriate - Remove some unused values files, service fields - Remove settings which should usually be changed from evm-rollup and sequencer `values.yaml` in favor of specifying in the dev override files. - Fix the CREATE2 script in alloc of evm rollup - Updated the default kind image, and cilium. Disable hubble by default - update local markdown lint to not hit any bridge contract sub module code - Added just convenience just commands for curling eth json rpc ## Testing Various local testing plus the CI/CD updated smoketest ## Breaking Changelist - New releases of many charts due to removal of default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the bridge withdrawer chart, updates smoke test to use it, improves the release process of charts, and has a slew of other chart upgrades to bring most of charts closer to same standard.
Background
We want to make sure the bridge withdrawal path works across changes, need chart for running in production.
Changes
evm-bridge-withdrawerhelm chartdeploy.justto default to using the deployed bridge and have init commands./chartsand the/devdirectory so you can utilize just the charts repo for lighter weight deployment.values.yamlin favor of specifying in the dev override files.Testing
Various local testing plus the CI/CD updated smoketest
Breaking Changelist