chore(cli)!: remove unmaintained rollup subcommand#1235
Merged
SuperFluffy merged 1 commit intomainfrom Jul 3, 2024
Merged
Conversation
SuperFluffy
force-pushed
the
superfluffy/remove-deployment-from-cli
branch
from
07c74c0 to
d00d38f
Compare
joroshiba
approved these changes
Jul 3, 2024
Member
joroshiba
left a comment
joroshiba
left a comment
There was a problem hiding this comment.
should we as follow up make the sequencer commands work at the top level/consider merging this and sequencer utils?
Contributor
Author
merging with sequencer utils: yes top level: no; I want to add a |
steezeburger
added a commit
that referenced
this pull request
Jul 11, 2024
* main: (27 commits) refactor(sequencer): fix prepare proposal metrics (#1211) refactor(bridge-withdrawer): move generated contract bindings to crate (#1237) fix(sequencer) fix wrong metric and remove unused metric (#1240) feat(sequencer): implement transaction fee query (#1196) chore(cli)!: remove unmaintained rollup subcommand (#1235) release(sequencer): 0.14.1 patch release (#1233) feat(sequencer-utils): generate example genesis state (#1224) feat(sequencer): implement abci query for bridge account info (#1189) feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141) chore(charts): update for new geth update (#1226) chore(chart)!: dusk-8 chart version updates (#1223) release(conductor): fix conductor release version (#1222) release: dusk-8 versions (#1219) fix(core): revert `From` ed25519_consensus types for crypto mod (#1220) Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193) refactor(withdrawer): read from block subscription stream and get events on each block (#1207) feat(core): implement with verification key for address builder and crypto improvements (#1218) feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209) chore(chart): update evm chart for new prefix field (#1214) chore: bump penumbra deps (#1216) ...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
## Summary This PR removes leftover unneeded code in the cli for managing rollup deployments. ## Background Just cleaning up the repo! ## Changes - Removes `crates/astria-cli/src/cli/rollup.rs` ## Testing - Locally built and ran the cli - Ran tests ## Related Issues Some previous work done here #1235, but this PR removes the last of the unneeded bits.
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Summary Removes the `rollup` subcommand from `astria-cli`. ## Background Deployment related logic has been moved from the monorepo's `astria-cli` to https://github.com/astriaorg/astria-cli-go. The current functionality is unmtained and likely broken. ## Changes - Remove the `rollup` subcommand from `astria-cli` and all related modules. ## Breaking Changelist Marked as a breaking change because functionality was removed. In practice this should not matter because nobody should be actively using the tool (no promise of maintenance, likely broken on HEAD).
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Summary This PR removes leftover unneeded code in the cli for managing rollup deployments. ## Background Just cleaning up the repo! ## Changes - Removes `crates/astria-cli/src/cli/rollup.rs` ## Testing - Locally built and ran the cli - Ran tests ## Related Issues Some previous work done here #1235, but this PR removes the last of the unneeded bits.
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
## Summary This PR removes leftover unneeded code in the cli for managing rollup deployments. ## Background Just cleaning up the repo! ## Changes - Removes `crates/astria-cli/src/cli/rollup.rs` ## Testing - Locally built and ran the cli - Ran tests ## Related Issues Some previous work done here astriaorg/astria#1235, but this PR removes the last of the unneeded bits.
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
## Summary This PR removes leftover unneeded code in the cli for managing rollup deployments. ## Background Just cleaning up the repo! ## Changes - Removes `crates/astria-cli/src/cli/rollup.rs` ## Testing - Locally built and ran the cli - Ran tests ## Related Issues Some previous work done here astriaorg/astria#1235, but this PR removes the last of the unneeded bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
rollupsubcommand fromastria-cli.Background
Deployment related logic has been moved from the monorepo's
astria-clito https://github.com/astriaorg/astria-cli-go. The current functionality is unmtained and likely broken.Changes
rollupsubcommand fromastria-cliand all related modules.Breaking Changelist
Marked as a breaking change because functionality was removed. In practice this should not matter because nobody should be actively using the tool (no promise of maintenance, likely broken on HEAD).