Skip to content

Comments

Revert "Allow --with-requirements to load extensionless inline-metadata scripts"#16861

Merged
zanieb merged 1 commit intomainfrom
zb/revert-requirement-sniff
Nov 26, 2025
Merged

Revert "Allow --with-requirements to load extensionless inline-metadata scripts"#16861
zanieb merged 1 commit intomainfrom
zb/revert-requirement-sniff

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Nov 26, 2025

Reverts #16805 / #16744

This also invalidates

There's probably a way we can make this work, but detecting whether a file is safe to read repeatedly is non-trivial, is_file returns true for /dev/stdin on macOS so the approach from #16857 is not sufficient. I spent a while trying to add is_char_device detection for macOS but unfortunately that didn't work.

@zanieb zanieb temporarily deployed to uv-test-registries November 26, 2025 14:47 — with GitHub Actions Inactive
@zanieb zanieb changed the title Revert "Allow --with-requirements to load extensionless inline-metadata scripts (#16805)" Revert "Allow --with-requirements to load extensionless inline-metadata scripts" Nov 26, 2025
@zanieb zanieb added the bug Something isn't working label Nov 26, 2025
@zanieb zanieb marked this pull request as ready for review November 26, 2025 14:47
@zanieb zanieb enabled auto-merge (squash) November 26, 2025 14:55
@zanieb zanieb merged commit ca62066 into main Nov 26, 2025
101 checks passed
@zanieb zanieb deleted the zb/revert-requirement-sniff branch November 26, 2025 14:57
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 27, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.11` -> `0.9.13` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.9.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0913)

[Compare Source](astral-sh/uv@0.9.12...0.9.13)

Released on 2025-11-26.

##### Bug fixes

- Revert "Allow `--with-requirements` to load extensionless inline-metadata scripts" to fix reading of requirements files from streams ([#&#8203;16861](astral-sh/uv#16861))
- Validate URL wheel tags against `Requires-Python` and required environments ([#&#8203;16824](astral-sh/uv#16824))

##### Documentation

- Drop unpublished crates from the uv crates.io README ([#&#8203;16847](astral-sh/uv#16847))
- Fix the links to uv in crates.io member READMEs ([#&#8203;16848](astral-sh/uv#16848))

### [`v0.9.12`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0912)

[Compare Source](astral-sh/uv@0.9.11...0.9.12)

Released on 2025-11-24.

##### Enhancements

- Allow `--with-requirements` to load extensionless inline-metadata scripts ([#&#8203;16744](astral-sh/uv#16744))
- Collect and upload PEP 740 attestations during `uv publish` ([#&#8203;16731](astral-sh/uv#16731))
- Prevent `uv export` from overwriting `pyproject.toml` ([#&#8203;16745](astral-sh/uv#16745))

##### Documentation

- Add a crates.io README for uv ([#&#8203;16809](astral-sh/uv#16809))
- Add documentation for intermediate Docker layers in a workspace ([#&#8203;16787](astral-sh/uv#16787))
- Enumerate workspace members in the uv crate README ([#&#8203;16811](astral-sh/uv#16811))
- Fix documentation links for crates ([#&#8203;16801](astral-sh/uv#16801))
- Generate a crates.io README for uv workspace members ([#&#8203;16812](astral-sh/uv#16812))
- Move the "Export" guide to the projects concept section ([#&#8203;16835](astral-sh/uv#16835))
- Update the cargo install recommendation to use crates ([#&#8203;16800](astral-sh/uv#16800))
- Use the word "internal" in crate descriptions ([#&#8203;16810](astral-sh/uv#16810))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xOS43IiwidXBkYXRlZEluVmVyIjoiNDIuMjEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
zanieb pushed a commit that referenced this pull request Dec 2, 2025
## Summary

This PR un-reverts #16861 by resolving extensionless sources with a
different strategy: we return an `Extensionless` variant, then infer the
type when we read the file and parse the contents immediately after,
thereby avoiding multiple reads.
zanieb pushed a commit that referenced this pull request Dec 2, 2025
This PR un-reverts #16861 by resolving extensionless sources with a
different strategy: we return an `Extensionless` variant, then infer the
type when we read the file and parse the contents immediately after,
thereby avoiding multiple reads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants