Validate URL wheel tags against `Requires-Python` and required environments by charliermarsh · Pull Request #16824 · astral-sh/uv

charliermarsh · 2025-11-23T21:08:49Z

Summary

charliermarsh · 2025-11-23T21:09:42Z

crates/uv/tests/it/lock.rs

+    ----- stderr -----
+      × No solution found when resolving dependencies:
+      ╰─▶ Because only numpy==2.3.5 is available and numpy==2.3.5 has no wheels with a matching Python version tag (e.g., `cp312`), we can conclude that all versions of numpy cannot be used.
+          And because your project depends on numpy, we can conclude that your project's requirements are unsatisfiable.


Today, this resolution passes and the wheel is just omitted from the lockfile.

charliermarsh · 2025-11-23T21:09:48Z

crates/uv/tests/it/lock.rs

+    ----- stderr -----
+      × No solution found when resolving dependencies:
+      ╰─▶ Because only numpy==2.3.5 is available and numpy==2.3.5 has no Windows-compatible wheels, we can conclude that all versions of numpy cannot be used.
+          And because your project depends on numpy, we can conclude that your project's requirements are unsatisfiable.


Same here -- this passes too.

konstin

One question about the resolver order, otherwise looks good.

konstin · 2025-11-24T12:51:09Z

crates/uv-resolver/src/resolver/mod.rs

+                for environment_marker in self.options.required_environments.iter().copied() {
+                    // If the platform is part of the current environment...
+                    if env.included_by_marker(environment_marker)
+                        && !find_environments(id, pubgrub).is_disjoint(environment_marker)


Here, we compute through which marker paths the package is currently reachable. Doesn't that mean we can miss an incompatible package if the dependency with a wider marker only appears later?

Hmm, maybe? But I think this is the same strategy as in the choose_version_registry path`.

It looks like we're getting saved by pseudo-packages having their version selection, with this PR this fails as it should:

[project] name = "test-toml" version = "0.1.0" requires-python = ">=3.14" dependencies = [ 'numpy; sys_platform == "win32"', 'pandas', ] [tool.uv] required-environments = ['sys_platform == "linux"', 'sys_platform == "win32"'] [tool.uv.sources] numpy = { url = "https://files.pythonhosted.org/packages/a3/2e/235b4d96619931192c91660805e5e49242389742a7a82c27665021db690c/numpy-2.3.5-cp314-cp314-win_amd64.whl" }

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.11` -> `0.9.13` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0913) [Compare Source](astral-sh/uv@0.9.12...0.9.13) Released on 2025-11-26. ##### Bug fixes - Revert "Allow `--with-requirements` to load extensionless inline-metadata scripts" to fix reading of requirements files from streams ([#16861](astral-sh/uv#16861)) - Validate URL wheel tags against `Requires-Python` and required environments ([#16824](astral-sh/uv#16824)) ##### Documentation - Drop unpublished crates from the uv crates.io README ([#16847](astral-sh/uv#16847)) - Fix the links to uv in crates.io member READMEs ([#16848](astral-sh/uv#16848)) ### [`v0.9.12`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0912) [Compare Source](astral-sh/uv@0.9.11...0.9.12) Released on 2025-11-24. ##### Enhancements - Allow `--with-requirements` to load extensionless inline-metadata scripts ([#16744](astral-sh/uv#16744)) - Collect and upload PEP 740 attestations during `uv publish` ([#16731](astral-sh/uv#16731)) - Prevent `uv export` from overwriting `pyproject.toml` ([#16745](astral-sh/uv#16745)) ##### Documentation - Add a crates.io README for uv ([#16809](astral-sh/uv#16809)) - Add documentation for intermediate Docker layers in a workspace ([#16787](astral-sh/uv#16787)) - Enumerate workspace members in the uv crate README ([#16811](astral-sh/uv#16811)) - Fix documentation links for crates ([#16801](astral-sh/uv#16801)) - Generate a crates.io README for uv workspace members ([#16812](astral-sh/uv#16812)) - Move the "Export" guide to the projects concept section ([#16835](astral-sh/uv#16835)) - Update the cargo install recommendation to use crates ([#16800](astral-sh/uv#16800)) - Use the word "internal" in crate descriptions ([#16810](astral-sh/uv#16810)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse.

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

Companion change for astral-sh/packse#293, motivated by #16824 (comment)

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

Companion change for astral-sh/packse#293, motivated by #16824 (comment)

Add a test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

Add astral-sh/packse#293 for #16824 (comment) Beware of mitsuhiko/insta#833 when working with packse for the time being (i.e., `cargo binstall cargo-insta@1.42.1 --force`)

Add requires python

edf39b3

charliermarsh added the bug Something isn't working label Nov 23, 2025

charliermarsh requested a review from konstin November 23, 2025 21:08

charliermarsh marked this pull request as ready for review November 23, 2025 21:08

Reverts

3542bfb

charliermarsh force-pushed the charlie/req branch from 1fce755 to 3542bfb Compare November 23, 2025 21:09

charliermarsh commented Nov 23, 2025

View reviewed changes

charliermarsh temporarily deployed to uv-test-registries November 23, 2025 21:17 — with GitHub Actions Inactive

konstin reviewed Nov 24, 2025

View reviewed changes

konstin approved these changes Nov 24, 2025

View reviewed changes

charliermarsh merged commit bfdee80 into main Nov 26, 2025
102 checks passed

charliermarsh deleted the charlie/req branch November 26, 2025 01:06

github-actions bot mentioned this pull request Nov 26, 2025

chore(deps): update ghcr.io/astral-sh/uv docker tag to v0.9.14 - autoclosed aignostics/python-sdk#280

Merged

1 task

BrewTestBot mentioned this pull request Nov 26, 2025

uv 0.9.13 Homebrew/homebrew-core#256105

Merged

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

2e23194

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse.

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

4f0f98a

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse.

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

5cb18d2

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

1833630

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

ad5981d

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

konstin mentioned this pull request Nov 27, 2025

Tests markers changing with required environments astral-sh/packse#293

Merged

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

d51f6b6

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

konstin added a commit that referenced this pull request Nov 27, 2025

Support required environments in packse

f239d66

Companion change for astral-sh/packse#293, motivated by #16824 (comment)

konstin mentioned this pull request Nov 27, 2025

Support required environments in packse #16873

Merged

konstin added a commit that referenced this pull request Nov 27, 2025

Support required environments in packse

90ff87e

Companion change for astral-sh/packse#293, motivated by #16824 (comment)

konstin added a commit to astral-sh/packse that referenced this pull request Nov 27, 2025

Tests markers changing with required-environments

8689b76

Test case for astral-sh/uv#16824 (comment). Introduces `required-environments` to packse, with a basic passing `requires-python-subset` case.

konstin added a commit that referenced this pull request Nov 27, 2025

Support required environments in packse (#16873)

f02b459

Companion change for astral-sh/packse#293, motivated by #16824 (comment)

konstin added a commit that referenced this pull request Nov 27, 2025

Update packse to 0.3.54

3bfc0bb

Add astral-sh/packse#293 for #16824 (comment) Beware of mitsuhiko/insta#833 when working with packse for the time being (i.e., `cargo binstall cargo-insta@1.42.1 --force`)

konstin mentioned this pull request Nov 27, 2025

Update packse to 0.3.54 #16876

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Validate URL wheel tags against `Requires-Python` and required environments#16824

Validate URL wheel tags against `Requires-Python` and required environments#16824
charliermarsh merged 2 commits intomainfrom
charlie/req

charliermarsh commented Nov 23, 2025

Uh oh!

charliermarsh Nov 23, 2025

Uh oh!

charliermarsh Nov 23, 2025

Uh oh!

konstin left a comment

Uh oh!

konstin Nov 24, 2025

Uh oh!

charliermarsh Nov 24, 2025

Uh oh!

konstin Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

charliermarsh commented Nov 23, 2025

Summary

Uh oh!

charliermarsh Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

charliermarsh Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

konstin left a comment

Choose a reason for hiding this comment

Uh oh!

konstin Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

charliermarsh Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

konstin Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants