Allow --with-requirements to load extensionless inline-metadata scripts#16805
Merged
charliermarsh merged 4 commits intomainfrom Nov 21, 2025
Merged
Conversation
…ine-meta…" This reverts commit 985abdc.
42b78a3 to
ffc6c0e
Compare
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 : ``` $ echo "flask" | uv pip install -r /dev/stdin warning: Requirements file `/dev/stdin` does not contain any dependencies Audited in 8ms ```
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 : ``` $ echo "flask" | uv pip install -r /dev/stdin warning: Requirements file `/dev/stdin` does not contain any dependencies Audited in 8ms ```
nsoranzo
added a commit
to nsoranzo/uv
that referenced
this pull request
Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 : ``` $ echo "flask" | uv pip install -r /dev/stdin warning: Requirements file `/dev/stdin` does not contain any dependencies Audited in 8ms ```
charliermarsh
pushed a commit
that referenced
this pull request
Nov 26, 2025
## Summary Fix ``uv pip install -r /dev/stdin`` which was broken in uv 0.9.12 by #16805 . Example of the issue: ``` $ echo "flask" | uv pip install -r /dev/stdin warning: Requirements file `/dev/stdin` does not contain any dependencies Audited in 8ms ``` Note that "upstream" ``pip install`` does support `-r /dev/stdin` and doesn't support `-r -` . ## Test Plan 2 new tests added.
zanieb
added a commit
that referenced
this pull request
Nov 26, 2025
…data scripts" (#16861) Reverts #16805 / #16744 This also invalidates - #16855 - #16857 There's probably a way we can make this work, but detecting whether a file is safe to read repeatedly is non-trivial, `is_file` returns `true` for `/dev/stdin` on macOS so the approach from #16857 is not sufficient. I spent a while trying to add `is_char_device` detection for macOS but unfortunately that didn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16802