Skip to content

Comments

Allow --with-requirements to load extensionless inline-metadata scripts#16805

Merged
charliermarsh merged 4 commits intomainfrom
revert-16802-revert-16744-with-req-inline-metadata
Nov 21, 2025
Merged

Allow --with-requirements to load extensionless inline-metadata scripts#16805
charliermarsh merged 4 commits intomainfrom
revert-16802-revert-16744-with-req-inline-metadata

Conversation

@charliermarsh
Copy link
Member

Reverts #16802

@charliermarsh charliermarsh force-pushed the revert-16802-revert-16744-with-req-inline-metadata branch from 42b78a3 to ffc6c0e Compare November 21, 2025 16:32
@charliermarsh charliermarsh marked this pull request as ready for review November 21, 2025 16:53
@charliermarsh charliermarsh merged commit f7f1592 into main Nov 21, 2025
102 checks passed
@charliermarsh charliermarsh deleted the revert-16802-revert-16744-with-req-inline-metadata branch November 21, 2025 16:53
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 .
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 :

```
$ echo "flask" | uv pip install -r /dev/stdin
warning: Requirements file `/dev/stdin` does not contain any dependencies
Audited in 8ms
```
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 :

```
$ echo "flask" | uv pip install -r /dev/stdin
warning: Requirements file `/dev/stdin` does not contain any dependencies
Audited in 8ms
```
nsoranzo added a commit to nsoranzo/uv that referenced this pull request Nov 26, 2025
which was broken in uv 0.9.12 by astral-sh#16805 :

```
$ echo "flask" | uv pip install -r /dev/stdin
warning: Requirements file `/dev/stdin` does not contain any dependencies
Audited in 8ms
```
charliermarsh pushed a commit that referenced this pull request Nov 26, 2025
## Summary

Fix ``uv pip install -r /dev/stdin`` which was broken in uv 0.9.12 by
#16805 .

Example of the issue:

```
$ echo "flask" | uv pip install -r /dev/stdin
warning: Requirements file `/dev/stdin` does not contain any dependencies
Audited in 8ms
```

Note that "upstream" ``pip install`` does support `-r /dev/stdin` and
doesn't support `-r -` .

## Test Plan

2 new tests added.
zanieb added a commit that referenced this pull request Nov 26, 2025
zanieb added a commit that referenced this pull request Nov 26, 2025
…data scripts" (#16861)

Reverts #16805 /
#16744

This also invalidates

- #16855
- #16857 

There's probably a way we can make this work, but detecting whether a
file is safe to read repeatedly is non-trivial, `is_file` returns `true`
for `/dev/stdin` on macOS so the approach from #16857 is not sufficient.
I spent a while trying to add `is_char_device` detection for macOS but
unfortunately that didn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant