Avoid eagerly reading input streams in -r#16857
Merged
charliermarsh merged 1 commit intomainfrom Nov 26, 2025
Merged
Conversation
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/empty
branch
from
bcbaa0f to
f7c518e
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
reviewed
Nov 26, 2025
Comment on lines
+72
to
+74
| // `-r <( cat requirements.lock | grep -v nvidia | grep -v torch==)` or similar, in | ||
| // which case, reading the input would consume the stream, and only `requirements.txt` | ||
| // format is supported anyway.) |
Member
There was a problem hiding this comment.
What do you mean by "only requirements.txt format is supported anyway"? It seems like you could do this with another file?
Member
|
Not blocking the bug fix, but... why not just hold on to the contents in memory if we need to sniff it? It seems a little weird to constrain streamed contents to |
Member
|
How does this relate to #16855 ? |
Member
zanieb
approved these changes
Nov 26, 2025
Member
Author
|
Yes, it regressed there; #16855 fixed one manifestation of this issue, but the problem is more general; yes, we should be storing the contents in-memory but this brings us back into parity with the code prior to those changes and fixes the regression. |
This was referenced Nov 26, 2025
zanieb
added a commit
that referenced
this pull request
Nov 26, 2025
…data scripts" (#16861) Reverts #16805 / #16744 This also invalidates - #16855 - #16857 There's probably a way we can make this work, but detecting whether a file is safe to read repeatedly is non-trivial, `is_file` returns `true` for `/dev/stdin` on macOS so the approach from #16857 is not sufficient. I spent a while trying to add `is_char_device` detection for macOS but unfortunately that didn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think the comment should explain it.
Closes #16856.