fix: cherry-pick fixed cli admin dashboard cmd#16457
Merged
alexmt merged 3 commits intoargoproj:release-2.9from Nov 27, 2023
Merged
fix: cherry-pick fixed cli admin dashboard cmd#16457alexmt merged 3 commits intoargoproj:release-2.9from
alexmt merged 3 commits intoargoproj:release-2.9from
Conversation
* chore(cli): clarify core mode code Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rename function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
alexmt
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-2.9 #16457 +/- ##
===============================================
+ Coverage 49.98% 50.00% +0.01%
===============================================
Files 266 267 +1
Lines 46074 46143 +69
===============================================
+ Hits 23030 23073 +43
- Misses 20784 20807 +23
- Partials 2260 2263 +3 ☔ View full report in Codecov by Sentry. |
jessesuen
approved these changes
Nov 27, 2023
13 tasks
Contributor
|
Hey @crenshaw-dev / @leoluz / @alexmt ... Friendly reminder that you have library/module consumers out there. Please be careful about changing function names and signatures... This is technically a breaking change - just got caught out by this when bumping versions on terraform-provider-argocd and the only mention of this in the release notes is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #15800 and #16430 into 2.9 release