fix(cli): copy ServerName into clientOpts in login command#16267
fix(cli): copy ServerName into clientOpts in login command#16267ishitasequeira merged 2 commits intoargoproj:masterfrom noam-codefresh:fix-login-port-forward
Conversation
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16267 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 269 269
Lines 46990 46991 +1
=======================================
+ Hits 23269 23272 +3
+ Misses 21437 21436 -1
+ Partials 2284 2283 -1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Noam Gal <noam.gal@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
|
/cherry-pick release-2.9 |
|
@crenshaw-dev @pasha-codefresh it seems like something went wrong as this has not made its way into the There was a related chery-pick #16457, but we probably also need this PR in 2.9. |
Signed-off-by: Noam Gal <noam.gal@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Noam Gal <noam.gal@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
|
@pasha-codefresh I think this is still not chery-picked into 2.9, are we only going to fix this bug in 2.10? |
|
the fix was merged to the main branch before |
Signed-off-by: Noam Gal <noam.gal@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Signed-off-by: Noam Gal <noam.gal@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Fixes #16266
this will pass the
ServerNameflag value (orARGOCD_SERVER_NAMEenv var) from theglobalClientOptsto the options used by the login command. when trying to login using--port-forwardthis value is needed.Checklist: