chore(ui): Change testEnvironment from node to jsdom#16287
Merged
alexmt merged 2 commits intoargoproj:masterfrom Nov 9, 2023
Merged
chore(ui): Change testEnvironment from node to jsdom#16287alexmt merged 2 commits intoargoproj:masterfrom
alexmt merged 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16287 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 269 269
Lines 46990 46990
=======================================
+ Hits 23269 23272 +3
+ Misses 21437 21435 -2
+ Partials 2284 2283 -1 ☔ View full report in Codecov by Sentry. |
13 tasks
Contributor
|
Thanks for this! I was wondering why these tests were failing in CI for my non-UI change.
This was also confusing me. For what it's worth I can reproduce this failure everytime locally if I run |
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Rafal Pelczar <rafal@akuity.io> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
alexmt
added a commit
that referenced
this pull request
Nov 27, 2023
* chore(cli): clarify core mode code (#15800) * chore(cli): clarify core mode code Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rename function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix: fixed cli admin dashboard cmd (#16430) * fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore(ui): Change testEnvironment from node to jsdom (#16287) Signed-off-by: Rafal Pelczar <rafal@akuity.io> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Rafal Pelczar <rafal@akuity.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Rafal <rafal@akuity.io>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Rafal Pelczar <rafal@akuity.io> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in some PRs failed because the testEnvironment option was set incorrectly. I have no idea why the tests sometimes passed. This change should fix that.
Checklist: