Skip to content

fix: fixed cli admin dashboard cmd#16430

Merged
alexmt merged 2 commits intoargoproj:masterfrom
gdsoumya:fix/cli_dashboardcmd
Nov 27, 2023
Merged

fix: fixed cli admin dashboard cmd#16430
alexmt merged 2 commits intoargoproj:masterfrom
gdsoumya:fix/cli_dashboardcmd

Conversation

@gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Nov 22, 2023 •
edited
Loading

Fixes #16379
Fixes #16323

Logs:

go run cmd/main.go admin dashboard -n argocd --address=127.0.0.2 --port 8888

Argo CD UI is available at http://127.0.0.2:8888

Issues resolved :

  1. Argocd server is able to start up when using argocd admin dashboard cmd
  2. The dashboard cmd is now able to parse both argocd specific flags like --address, --port etc. and also k8s flags like -n

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gdsoumya
fix: fixed cli admin dashboard cmd
9a7127f 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested a review from a team as a code owner November 22, 2023 20:37
@codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1600c03) 49.53% compared to head (3c97a6a) 49.53%.

Files Patch % Lines
cmd/argocd/commands/admin/dashboard.go 0.00% 5 Missing ⚠️
cmd/argocd/commands/admin/admin.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16430      +/-   ##
==========================================
- Coverage   49.53%   49.53%   -0.01%     
==========================================
  Files         269      269              
  Lines       47222    47224       +2     
==========================================
  Hits        23392    23392              
- Misses      21530    21532       +2     
  Partials     2300     2300

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira previously requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdsoumya , the generated code seems to be a mismatch. Can you take a look?

gdsoumya
gdsoumya commented Nov 23, 2023
View reviewed changes
cmd/argocd/commands/admin/dashboard.go
`,
}
initialize.InitCommand(cmd)
clientConfig = cli.AddKubectlFlagsToSet(cmd.Flags())
Copy link
Member Author

@gdsoumya gdsoumya Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without passing the clientConfig directly from the cmd I was not able to use kubectl like flags to configure the cliebntConfig for eg. -n/--namespace was not working before this change. A similar issue was noticed by another user

@gdsoumya
feat: update docs
3c97a6a 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested a review from a team as a code owner November 23, 2023 06:06
@gdsoumya
Copy link
Member Author

gdsoumya commented Nov 23, 2023

@ishitasequeira updated docs

alexmt
alexmt approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @gdsoumya !

@alexmt alexmt added the cherry-pick/2.9 Candidate for cherry picking into the 2.9 release branch label Nov 26, 2023
@alexmt
Copy link
Collaborator

alexmt commented Nov 26, 2023

Double-checked that most recent v2.8 is not affected, so cherry-picking only into 2.9

@alexmt alexmt enabled auto-merge (squash) November 26, 2023 21:14
@alexmt alexmt merged commit 2f2958a into argoproj:master Nov 27, 2023
@alexmt
Copy link
Collaborator

alexmt commented Nov 27, 2023

/cherry-pick release-2.9

@gcp-cherry-pick-bot
Copy link

gcp-cherry-pick-bot bot commented Nov 27, 2023

Cherry-pick failed with Merge error 2f2958a0f42068552de67370caccb84522267c65 into temp-cherry-pick-ea997a-release-2.9

@mikutas mikutas mentioned this pull request Nov 27, 2023
Closed
13 tasks
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Nov 27, 2023
@gdsoumya @alexmt
fix: fixed cli admin dashboard cmd (argoproj#16430)
04e69ad 
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@alexmt alexmt mentioned this pull request Nov 27, 2023
Merged
alexmt added a commit that referenced this pull request Nov 27, 2023
@alexmt @crenshaw-dev
@gdsoumya @rpelczar
fix: cherry-pick fixed cli admin dashboard cmd (#16457)
e63273e 
* chore(cli): clarify core mode code (#15800)

* chore(cli): clarify core mode code

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* rename function

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix: fixed cli admin dashboard cmd (#16430)

* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* chore(ui): Change testEnvironment from node to jsdom (#16287)

Signed-off-by: Rafal Pelczar <rafal@akuity.io>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
Co-authored-by: Rafal <rafal@akuity.io>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@gdsoumya @vladfr
fix: fixed cli admin dashboard cmd (argoproj#16430)
2e5d4b2 
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@gdsoumya @tesla59
fix: fixed cli admin dashboard cmd (argoproj#16430)
68587cf 
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@gdsoumya @lyda
fix: fixed cli admin dashboard cmd (argoproj#16430)
db21c0d 
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@gdsoumya @Hariharasuthan99
fix: fixed cli admin dashboard cmd (argoproj#16430)
31412f7 
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexmt alexmt alexmt approved these changes

@ishitasequeira ishitasequeira Awaiting requested review from ishitasequeira

Assignees

No one assigned

Labels

cherry-pick/2.9 Candidate for cherry picking into the 2.9 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argocd admin dasboard --address isn't propagated argocd admin dashboard - FATA[0002] cannot find pod with selector: [app.kubernetes.io/name=]

3 participants

@gdsoumya @alexmt @ishitasequeira