docs: Document ApplyOutOfSyncOnly in application spec#16282
Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom Nov 9, 2023
Merged
Conversation
matthewhughes-uw
force-pushed
the
document-applyoutofsync-in-application-specification
branch
from
1a9b2f4 to
85a57d1
Compare
Contributor
Author
|
Failing lint job is unrelated, looks to be addressed in #16275 EDIT: rebasing to include those changes fixed the issues in the Go tests/linting but there remain failures in the UI integration tests. As far as I can tell these are unrelated to the doc changes (the same failures are present in the latest build on EDIT EDIT: the UI tests should be fixed with #16287 |
matthewhughes-uw
force-pushed
the
document-applyoutofsync-in-application-specification
branch
from
85a57d1 to
c304160
Compare
ishitasequeira
approved these changes
Nov 9, 2023
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks @matthewhughes-uw, LGTM!
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk>
auto-merge was automatically disabled
November 9, 2023 15:10
Head branch was pushed to by a user without write access
matthewhughes-uw
force-pushed
the
document-applyoutofsync-in-application-specification
branch
from
c304160 to
93e9752
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16282 +/- ##
=======================================
Coverage 49.52% 49.52%
=======================================
Files 269 269
Lines 46990 46990
=======================================
Hits 23272 23272
Misses 21435 21435
Partials 2283 2283 ☔ View full report in Codecov by Sentry. |
Contributor
Author
Thanks for the review @ishitasequeira. I've forced pushed the branch after rebasing to include the CI fix from #16287 which dismissed your auto merge |
ishitasequeira
approved these changes
Nov 9, 2023
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the `sync-options` docs[2] (see also baa0f2e) [1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/ [2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync Signed-off-by: Matt Hughes <mhughes@uw.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this being used in an application I was working on but had a hard time discovering its meaning since it wasn't in the specification[1] though it was in the
sync-optionsdocs (see also baa0f2e)[1] https://argo-cd.readthedocs.io/en/stable/user-guide/application-specification/
[2] https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#selective-sync
Checklist:
Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or(c) this does not need to be in the release notes.