fix(app): use jsonpatch to check for changes in status field (#15126) by vladfr · Pull Request #15227 · argoproj/argo-cd

vladfr · 2023-08-24T17:17:14Z

This PR changes the way patches are computed for annotations and status. Because Helm source can have unstructured fields in helm.valuesObject, the strategic patching gives unpredictable behaviour. It was never meant to be used without a struct (see Helm Issue). So we use jsonpatch instead. This should yield the same results, and the library is already present in Argo as a dependency.

Checklist:

Fixes #15126

vladfr · 2023-08-25T06:40:22Z

I couldn't really find a good spot for the utility function. It should be moved in gitops-engine at some point.

jannfis

LGTM, thanks for fixing this!

I agree that it should move into gitops-engine later on. We probably need to revive lifecycle management between gitops-engine and Argo CD before, or migrate gitops-engine back into Argo CD though.

For now, I'm fine with this code living in the application controller.

Just for clarification and my understanding, this only affects valuesObject introduced in 2.8, right?

crenshaw-dev · 2023-08-25T13:57:12Z

@jannfis this fixes a problem with the new field, but it changes how we calculate the app status for every field, so it's pretty darn central.

jannfis · 2023-08-25T14:16:55Z

@crenshaw-dev Yes, I was rather referring to the bug it fixes. So the bug is only in 2.8, and we need to cherry-pick only into that?

crenshaw-dev · 2023-08-25T14:18:40Z

@jannfis yep!

jannfis · 2023-08-25T14:22:19Z

And I would assume that since every test, including end-to-end, pass without changes that the change itself is fine. The only concern might be a performance impact of CreateTwoWayMergePatch (which is part of the Kubernetes distribution) and the JSON merge patch we pull in from github.com/evanphx/json-patch (and we seem to pull a pretty outdated version).

vladfr · 2023-08-27T12:05:23Z

@jannfis the helm.valuesObject field was added in 2.8.0, so I can confirm that the bugfix is meant only for 2.8.x

You have valid points about adding changes to a critical point. I figured it's safe since jsonpatch is so widely used, and it's already a dep, and tests pass :) We could definitely do a series of benches to see how performance looks.

I can dig a bit to see if there's another way to handle this fix. It seems the problem lies in how the object is being stored in status, so we can look at the way it's stored; or perhaps transform valuesObject before the patching is done (load it up and marshal again).

PS: I'm out next week, but I can take another approach after I'm back, or if someone else has input until then, feel free.

jannfis · 2023-08-29T15:58:43Z

@vladfr I think a good first step would be to use a recent version of jsonpatch, e.g. github.com/evanphx/json-patch/v5

Zeratoxx · 2023-12-06T11:34:15Z

Hi, is this PR still watched? :)

vladfr · 2023-12-13T11:35:40Z

Hi, sorry for my big delay here.

I've looked for a different way to address this. Unfortunately, it's not really clear how I can change the logic to store the valuesObject field separately; besides which, I'm not really sure what's causing the issue with the quotes.

So I've modified the patching code to:

ignore valuesObject when computing the strategic merge patch
compute diff on valuesObject using jsonpatch
apply two patches if needed

PS: I'd like to add an e2e test for this, but I'm still struggling a bit with running these locally.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

…oproj#15583) Bumps library/node from 20.6.1 to 20.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…er (argoproj#15585) Bumps library/node from 20.6.1 to 20.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>

…in "high availibility" doc (argoproj#5348) (argoproj#13258) Signed-off-by: Sridhar Nandigam <nandigamsridhar.v@gmail.com>

Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>

…oproj#15595) * feat: added patch_ms to reconciliation logs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: added patch_ms and setop_ms timings to logs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* chore(action): add newlines at eof Signed-off-by: Josh Soref <jsoref@gmail.com> * chore(action): fix whitespace indentation Signed-off-by: Josh Soref <jsoref@gmail.com> * chore(action): use local annotations Signed-off-by: Josh Soref <jsoref@gmail.com> --------- Signed-off-by: Josh Soref <jsoref@gmail.com>

…j#15615) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

…rting API-Server (argoproj#15574) * feat: auto configure extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: auto-reload extension configs without restarting api-server Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * clean unused gorilla mux Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * update docs Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Add more test cases Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * refactoring to reduce unnecessary function Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Add log Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix bugs found during manual tests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

…oc (argoproj#15619) The supported version policy mentioned in the operator manual installation document diverges from the official policy that is mentioned in the security policy and the release cadence. This change brings the version policy in line by referring the readers to the release and cadence documentation to check the specified policy. Signed-off-by: Muhammad Mooneeb Hussain <mooneeb.hussain@gmail.com>

Signed-off-by: Timoses <timoses@tutanota.com>

…rollback for tree view (argoproj#15572) * app sync and app wait tree view changes Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * documentation changes Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * included the json,yaml and wide formats and removed the value assignment to the flag Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Reoved extra spaces Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * removed extra spaces Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * refactored the code Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * better log statements Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>

* Migrate Application Controller from Statefulset to Deployment Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add sharding deployment logic Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Update sharding logic and add comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add heartbeat as an environment variable Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add retry logic, heartbeat timeout environment variable Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * use the logic of pre-specified shard number on application controller pod Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix manifests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix lint and e2e tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * comment out failing e2e test Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * increase readiness probe interval period Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * "comment out readiness probe to see if e2e tests succeed" Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert commented readiness probe Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert commented test case Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * read environment variable for application controller deployment name Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add nil check on replica count for deployment of application controller Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add Informer, Update documentation, add unit tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update godoc Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * remove unwanted code and logs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add more documentation Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert ApplicationController manifest to StatefulSet Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * reverting updated docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add documentation for the new dynamic distribution feature Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update documentation Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add an overlay for application controller deployment and update documentation Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix nit Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Marking the feature as alpha Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add feature status link Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert go,mod changes Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update docs to avoid focusing on StatefulSet/Deployment (argoproj#26) * update docs to avoid focusing on StatefulSet/Deployment Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * minor update to the doc Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* chore(deps): bump node version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * update lockfile Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* self service notification Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification engine Signed-off-by: May Zhang <may_zhang@intuit.com> * re-trigger build Signed-off-by: May Zhang <may_zhang@intuit.com> * self service notification Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification engine Signed-off-by: May Zhang <may_zhang@intuit.com> * re-trigger build Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification enginer version Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification enginer version Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <may_zhang@intuit.com> * add cm and secret to clusterRole Signed-off-by: May Zhang <may_zhang@intuit.com> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix merge conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix doc and test based on review Signed-off-by: May Zhang <may_zhang@intuit.com> * self service notification Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification engine Signed-off-by: May Zhang <may_zhang@intuit.com> * re-trigger build Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * self service notification Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * revert back the changes for redis-ha Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification engine Signed-off-by: May Zhang <may_zhang@intuit.com> * re-trigger build Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * fix conflict Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification enginer version Signed-off-by: May Zhang <may_zhang@intuit.com> * update notification enginer version Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * fixing go tidy Signed-off-by: May Zhang <may_zhang@intuit.com> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <may_zhang@intuit.com> * add cm and secret to clusterRole Signed-off-by: May Zhang <may_zhang@intuit.com> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix doc and test based on review Signed-off-by: May Zhang <may_zhang@intuit.com> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <may_zhang@intuit.com> * tweaks Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix docs formatting Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix: Tooltips point in wrong direction#11935 Signed-off-by: Teng, Jessie <yilin.teng@fmr.com> * fix: Tooltips point in wrong direction#11935 Signed-off-by: Teng <yilin.teng@fmr.com> --------- Signed-off-by: Teng, Jessie <yilin.teng@fmr.com> Signed-off-by: Teng <yilin.teng@fmr.com> Co-authored-by: Teng, Jessie <a715260@fmr.com>

* fix(11164): Advanced templating using patchTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * small changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

…sInAnyNamespaceEnabled flag is set (argoproj#16249) Signed-off-by: Eilers, Jonas <133217951+jdvgh@users.noreply.github.com>

…rgoproj#16062) (argoproj#16241) * fix(appset): store sha from webhook to get latest change during reconcile (argoproj#16062) Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com> * fix(appset): Don't use revision cache when reconciling after webhook(argoproj#16062) Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com> --------- Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com>

Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>

…ssue argoproj#16523) (argoproj#16520) * Update cert-manager.opcertificate health.lua Signed-off-by: Chris Murray <chris@distrail.io> * adding test case for cert issuing Signed-off-by: Chris Murray <chris@distrail.io> * fixing typo Signed-off-by: Chris Murray <chris@distrail.io> --------- Signed-off-by: Chris Murray <chris@distrail.io>

…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>

…rgoproj#15902)

Signed-off-by: Josh Soref <jsoref@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>

Signed-off-by: Phil Nichol <35630607+philnichol@users.noreply.github.com>

…6560) Signed-off-by: Jesse Suen <jesse@akuity.io>

…proj#16364) Signed-off-by: Rotem Tamir <rotemtamir@gmail.com>

… allow app's deletion (argoproj#12172) (argoproj#16506) * fix(appset): remove unnecessary condition Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> * docs: update explanation about policy Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> --------- Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

Signed-off-by: Jay Shah <jay.shah@konghq.com>

…oj#16581) * chore: upgrade kubernetes dependencies from 0.26.4 to 0.26.11 Fixes some vulnerabilities trivy is reporting on (not necessarily vulnerabe, trivy tends to have a lot of false positives when it comes to golang projects): * CVE-2023-3676 * CVE-2023-3955 * CVE-2023-5528 * CVE-2023-2431 * CVE-2023-2727 * CVE-2023-2728 Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com> * go mod tidy Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com> * Add go mod tidy to kubernetes updater script Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com> --------- Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>

Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>

…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>

when applying a patch, the rawextenstion object used for valuesObject needs to be diffed with jsonpatch instead of the default strategic merge Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

vladfr · 2023-12-13T15:13:52Z

@crenshaw-dev The new code now uses jsonpatch only for valuesObject. I've managed to arrive at a workable solution, not very happy on how it looks. Pointers appreciated!

PS: Sorry about this, I've mistakenly ran a rebase. We can cut another PR once this is closer to being merged. (i.e. add tests)

PaulSonOfLars · 2023-12-13T22:47:58Z

Thanks for the hard work @vladfr, I think that should work!

I added some tests on the my branch on #16602. Wasn't sure how you wanted to go forward regarding merging - feel free to cherry pick my changes here if you'd prefer the merge attribution in your name for finding the "fix" itself.

vladfr · 2024-03-25T14:54:42Z

Closing in favor of #16602

vladfr force-pushed the 15126-jsonpatch branch 2 times, most recently from 50f7680 to 3f533d8 Compare August 25, 2023 06:23

mikebryant approved these changes Aug 25, 2023

View reviewed changes

jannfis approved these changes Aug 25, 2023

View reviewed changes

Jrc356 mentioned this pull request Dec 1, 2023

Error constructing app status patch: unable to find api field in struct RawExtension for the json field \"autoscaling\" #15126

Closed

3 tasks

vladfr requested a review from a team as a code owner December 13, 2023 11:32

crenshaw-dev and others added 15 commits December 13, 2023 13:49

docs: better command reference titles (argoproj#15567) (argoproj#15568)

bfe9594

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

docs: Add documentation on how to specify shard number for a cluster …

f4980d0

…in "high availibility" doc (argoproj#5348) (argoproj#13258) Signed-off-by: Sridhar Nandigam <nandigamsridhar.v@gmail.com>

docs: 'action' RBAC example for Kind without group (argoproj#15589)

9b2df1e

chore: add gdsoumya to reviewers (argoproj#15596)

e8214f5

Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>

chore(deps): bump library/golang from cffaba7 to 2270a40 (argopro…

eab2ce4

…j#15615) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

doc: resource tracking custom label configuration (argoproj#15587)

17f8d7d

Signed-off-by: Timoses <timoses@tutanota.com>

mayzhang2000 and others added 22 commits December 13, 2023 13:52

feat(ui): Add sourceNamespaces in Projects UI and only show it if App…

f4d4b69

…sInAnyNamespaceEnabled flag is set (argoproj#16249) Signed-off-by: Eilers, Jonas <133217951+jdvgh@users.noreply.github.com>

fix(doc): Fix documentation templatePatch (argoproj#16522)

d7d8a4d

Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>

fix: Use math.MaxInt (instead of math.MaxInt64) to fix builds on 32bi…

c308c57

…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>

Added missing 'alias:' prefix for repository name as described here: (a…

5a7ca83

…rgoproj#15902)

fix(ui): use background delete to match k8s terminology (argoproj#15579)

6a6b20d

Signed-off-by: Josh Soref <jsoref@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

docs: Fix format issue in rbac.md (argoproj#16521)

3cc02e2

Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>

docs: Fix minor typo in Declarative Setup (argoproj#16550)

376f5fa

Signed-off-by: Phil Nichol <35630607+philnichol@users.noreply.github.com>

chore: update PR template to suggest cherry-pick releases (argoproj#1…

14d9043

…6560) Signed-off-by: Jesse Suen <jesse@akuity.io>

resource_customizations/db.atlasgo.io: atlas operator resources (argo…

6180bb8

…proj#16364) Signed-off-by: Rotem Tamir <rotemtamir@gmail.com>

docs: Add Kong Inc. as a user (argoproj#16582)

4d8a63e

Signed-off-by: Jay Shah <jay.shah@konghq.com>

docs: fix broken link in secret-management.md (argoproj#16588)

1bb3828

Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>

docs(monitoring): add new ServiceMonitors for redis, dex, notificatio…

9384e43

…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>

use jsonpatch just for the valuesObject field

a321d27

when applying a patch, the rawextenstion object used for valuesObject needs to be diffed with jsonpatch instead of the default strategic merge Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

update patchMs to time both conditions; use writeback

973868a

Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

merge patches and apply only once, treat null pointers

eb27b2d

Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

vladfr requested review from a team as code owners December 13, 2023 15:09

Merge branch 'master' into 15126-jsonpatch

57617ed

Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>

PaulSonOfLars mentioned this pull request Dec 13, 2023

fix(app): Fix patch creation for Applications with ValuesObject fields #15126 #16602

Closed

14 tasks

vladfr closed this Mar 25, 2024

Conversation

vladfr commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vladfr commented Aug 25, 2023

Uh oh!

jannfis left a comment

Choose a reason for hiding this comment

Uh oh!

crenshaw-dev commented Aug 25, 2023

Uh oh!

jannfis commented Aug 25, 2023

Uh oh!

crenshaw-dev commented Aug 25, 2023

Uh oh!

jannfis commented Aug 25, 2023

Uh oh!

vladfr commented Aug 27, 2023

Uh oh!

jannfis commented Aug 29, 2023

Uh oh!

Zeratoxx commented Dec 6, 2023

Uh oh!

vladfr commented Dec 13, 2023

Uh oh!

vladfr commented Dec 13, 2023

Uh oh!

PaulSonOfLars commented Dec 13, 2023

Uh oh!

vladfr commented Mar 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

vladfr commented Aug 24, 2023 •

edited

Loading