Skip to content

fix: Tooltips point in wrong direction#11935#12578

Merged
crenshaw-dev merged 5 commits intoargoproj:masterfrom
fidelity-contributions:fidelity-20230119-153731
Dec 1, 2023
Merged

fix: Tooltips point in wrong direction#11935#12578
crenshaw-dev merged 5 commits intoargoproj:masterfrom
fidelity-contributions:fidelity-20230119-153731

Conversation

@JessieTeng89
Copy link
Contributor

@JessieTeng89 JessieTeng89 commented Feb 23, 2023

fix: incomplete confirmation dialogue
Fixes #11644

JessieTeng89 and others added 4 commits January 19, 2023 17:11
@JessieTeng89 JessieTeng89 mentioned this pull request Nov 28, 2023
Closed
@JessieTeng89 JessieTeng89 requested a review from a team as a code owner November 29, 2023 11:37
@JessieTeng89
Copy link
Contributor Author

JessieTeng89 commented Nov 29, 2023

Hi @jsoref @saumeya @alexmt
As discussed in another PR #12200, I fixed the issue #11644 with this PR using media query way.
Could you please check and approve it if no other issues? Or please let me know if any other action is needed.
Thanks!

@JessieTeng89
Copy link
Contributor Author

JessieTeng89 commented Nov 30, 2023

FYI @crenshaw-dev
Kindly help to review this PR

ishitasequeira
ishitasequeira approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@JessieTeng89
Copy link
Contributor Author

JessieTeng89 commented Dec 1, 2023

LGTM!!

Thanks for your approval, can I know how we can merge the PR?

@crenshaw-dev crenshaw-dev merged commit 8656585 into argoproj:master Dec 1, 2023
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@JessieTeng89 @vladfr
fix: Tooltips point in wrong direction#11935 (argoproj#12578)
57ba868 
* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>

* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng <yilin.teng@fmr.com>

---------

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Signed-off-by: Teng <yilin.teng@fmr.com>
Co-authored-by: Teng, Jessie <a715260@fmr.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@JessieTeng89 @tesla59
fix: Tooltips point in wrong direction#11935 (argoproj#12578)
b169c82 
* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>

* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng <yilin.teng@fmr.com>

---------

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Signed-off-by: Teng <yilin.teng@fmr.com>
Co-authored-by: Teng, Jessie <a715260@fmr.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@JessieTeng89
fix: Tooltips point in wrong direction#11935 (argoproj#12578)
8e31daa 
* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>

* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng <yilin.teng@fmr.com>

---------

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Signed-off-by: Teng <yilin.teng@fmr.com>
Co-authored-by: Teng, Jessie <a715260@fmr.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@JessieTeng89 @lyda
fix: Tooltips point in wrong direction#11935 (argoproj#12578)
03deb57 
* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>

* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng <yilin.teng@fmr.com>

---------

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Signed-off-by: Teng <yilin.teng@fmr.com>
Co-authored-by: Teng, Jessie <a715260@fmr.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@JessieTeng89 @Hariharasuthan99
fix: Tooltips point in wrong direction#11935 (argoproj#12578)
b18f488 
* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>

* fix: Tooltips point in wrong direction#11935

Signed-off-by: Teng <yilin.teng@fmr.com>

---------

Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
Signed-off-by: Teng <yilin.teng@fmr.com>
Co-authored-by: Teng, Jessie <a715260@fmr.com>
@metavida
Copy link

metavida commented Aug 8, 2024

Question: Does this PR really fix really address issue #11644 which is about a missing checkbox label in the "Delete pod" confirmation dialogue?

I ask because the changes in this PR seem related to a Tooltip component and the the related PR #12200 mentioned by @JessieTeng89 above does indeed contain a screenshot of a tooltip and not the "Delete pod" confirmation dialog.

Maybe this PR instead fixes issue #11935 ?

@JessieTeng89
Copy link
Contributor Author

JessieTeng89 commented Aug 9, 2024

Question: Does this PR really fix really address issue #11644 which is about a missing checkbox label in the "Delete pod" confirmation dialogue?

I ask because the changes in this PR seem related to a Tooltip component and the the related PR #12200 mentioned by @JessieTeng89 above does indeed contain a screenshot of a tooltip and not the "Delete pod" confirmation dialog.

Maybe this PR instead fixes issue #11935 ?

I think you are right, this PR is to fix issue #11935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ui: incomplete confirmation dialogue

4 participants

@JessieTeng89 @metavida @ishitasequeira @crenshaw-dev