docs(monitoring): update metrics.md - add Service Monitors for dex, notifications and redis#16534
Merged
blakepettersson merged 2 commits intoargoproj:masterfrom Dec 13, 2023
Merged
Conversation
dmpe
changed the title
dmpe
commented
Dec 5, 2023
dmpe
commented
Dec 5, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16534 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 270 270
Lines 47489 47489
=======================================
Hits 23506 23506
Misses 21672 21672
Partials 2311 2311 ☔ View full report in Codecov by Sentry. |
chengfang
reviewed
Dec 5, 2023
chengfang
reviewed
Dec 5, 2023
Contributor
Author
|
Thank for review, will do within the next 24 hours ... |
dmpe
changed the title
dmpe
commented
Dec 5, 2023
Contributor
Author
I have add some smaller fixes. Can you take a look again pls :) Many thanks. |
chengfang
approved these changes
Dec 5, 2023
Signed-off-by: dmpe <cincenko@outlook.com>
Contributor
Author
|
Commits squashed, rebased and pushed again. |
blakepettersson
approved these changes
Dec 7, 2023
Contributor
Author
|
Can someone merge this ? |
Member
|
Sorry missed the actual merge, LGTM! 🎉 |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…ns (argoproj#16534) Signed-off-by: dmpe <cincenko@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been tested with almost latest
argocd 2.9.2and latest prometheus operator.Checklist: