fix: cert-manager.io/certificate health.lua for consistent issuing (Issue #16523)

[chr15murray]

Fixes [ISSUE #16523]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

The health of a cert-manager.io/certificate is not always consistent within ArgoCD when Issuing and Ready states both exist. This occurs because the Ready: False state may come first or second in the status conditions.

Example Degraded

status:
  conditions:
    - lastTransitionTime: '2023-12-01T11:15:28Z'
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: 'False'
      type: Ready
    - lastTransitionTime: '2023-12-01T11:15:28Z'
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: 'True'
      type: Issuing
  nextPrivateKeySecretName: certtest-81-vg977

Example Issuing

status:
  conditions:
    - lastTransitionTime: '2023-12-01T11:15:28Z'
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: 'True'
      type: Issuing
    - lastTransitionTime: '2023-12-01T11:15:28Z'
      message: Issuing certificate as Secret does not exist
      observedGeneration: 1
      reason: DoesNotExist
      status: 'False'
      type: Ready
  nextPrivateKeySecretName: certtest-82-f4r27

This PR checks for Issuing first and places the resource health into 'Progressing' state if True before considering the Ready status.

I've also add a new test case for this. With the previous health check that test case would be in a Degraded state.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7408292) 49.49% compared to head (b2bf6b3) 49.49%.

❗ Current head b2bf6b3 differs from pull request most recent head 49129c7. Consider uploading reports for the commit 49129c7 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #16520   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files         270      270           
  Lines       47485    47485           
=======================================
+ Hits        23501    23502    +1     
+ Misses      21673    21672    -1     
  Partials     2311     2311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ishitasequeira]

Thanks @chr15murray!! LGTM!!

[cyrus-mc]

With this change, certificates always show as "Progressing". Given that it loops over all status first, looking for type Issuing and bailing if found, it never sees the status indicating that the certificate was renewed.

As an example, here is the status field

status:
  conditions:
  - lastTransitionTime: "2024-04-09T23:38:04Z"
    message: Certificate is up to date and has not expired
    observedGeneration: 1
    reason: Ready
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-06-08T22:38:03Z"
    message: Renewing certificate as renewal was scheduled at 2024-06-08 22:38:03
      +0000 UTC
    observedGeneration: 1
    reason: Renewing
    status: "True"
    type: Issuing

The certificate renewal was issued, but the logic will see the second status and set the status to Progressing.

[crenshaw-dev]

@cyrus-mc can you open an issue?

[cyrus-mc]

@crenshaw-dev Issue created.