fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (#13813)#14216
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Jul 20, 2023
Conversation
e146e7b to
a08420c
Compare
jmeridth
approved these changes
Jun 26, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14216 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44659 44659
=======================================
Hits 22225 22225
Misses 20249 20249
Partials 2185 2185 ☔ View full report in Codecov by Sentry. |
jmeridth
approved these changes
Jun 27, 2023
…ination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
692ab2e to
c2e73d6
Compare
10 tasks
jmeridth
approved these changes
Jul 7, 2023
Member
|
@crenshaw-dev viable for merge or has to wait post 2.8 stuff? Thank you. |
ishitasequeira
approved these changes
Jul 13, 2023
Contributor
|
I can confirm ui-test is OK! |
ebuildy
approved these changes
Jul 20, 2023
Member
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Member
|
/cherry-pick release-2.7 |
Member
|
/cherry-pick release-2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…ination field (argoproj#13813) (argoproj#14216) (argoproj#14627) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) * Address linting errors --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Closed
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Sep 30, 2023
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
This was referenced Dec 2, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13813
Currently, when users attempt to choose
NAMEin the Destination dropdown, the inner state does not change. With this PR, we move the loading of the destFormat state into a useEffect, which should address when we were reloading our state. Also addresses a React warning related to mutating our state outside of our component:Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.